[GitHub] [hive] aasha commented on a change in pull request #1249: HIVE-23835 Repl Dump should dump function binaries to staging directory

[GitBox <gi...@apache.org>]

aasha commented on a change in pull request #1249:
URL: https://github.com/apache/hive/pull/1249#discussion_r454934068



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java
##########
@@ -217,6 +217,52 @@ public static void setNullSrcPath(HiveConf conf, boolean aNullSrcPath) {
     }
   }
 
+
+  /**
+   * Wrapper class for mapping source and target path for copying function binaries.
+   */
+  public static class FunctionBinaryCopyPath {

Review comment:
       is this class any different from the table copy path. If not can we reuse?

##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestReplDumpTask.java
##########
@@ -87,7 +87,9 @@ String getValidTxnListForReplDump(Hive hiveDb, long waitUntilTime) {
     }
 
     @Override
-    void dumpFunctionMetadata(String dbName, Path dbMetadataRoot, Hive hiveDb) {
+    List<EximUtil.FunctionBinaryCopyPath> dumpFunctionMetadata(String dbName, Path dbMetadataRoot, Path dbDataRoot,
+                                                               Hive hiveDb) {

Review comment:
       do we dump function in case of metadata only replication?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org