You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2023/03/07 16:55:44 UTC

[GitHub] [phoenix-queryserver] stoty opened a new pull request, #122: PHOENIX-6892 Add support for SqlAlchemy 2.0

stoty opened a new pull request, #122:
URL: https://github.com/apache/phoenix-queryserver/pull/122

   also replace deprecated assert functions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix-queryserver] richardantal commented on a diff in pull request #122: PHOENIX-6892 Add support for SqlAlchemy 2.0

Posted by "richardantal (via GitHub)" <gi...@apache.org>.
richardantal commented on code in PR #122:
URL: https://github.com/apache/phoenix-queryserver/pull/122#discussion_r1142139761


##########
python-phoenixdb/NEWS.rst:
##########
@@ -1,6 +1,17 @@
 Changelog
 =========
 
+Unreleased
+----------
+- Update python-phoenixdb/RELEASING.rst (PHOENIX-6820)
+- Add Python 3.11 to supported languages and update docker test image for phoenixdb (PHOENIX-6858)
+- Document workaround for PhoenixDB 1.2+ not working with Python2 on some systems (PHOENIX-6863)
+- Update install instructions in README.rst (PHOENIX-6812)
+- Add support for SQLAlchemy 2.0 (PHOENIX-6892)
+- SQLAlchemy is no longer an install dependency (PHOENIX-6892)
+- Run tests with all supported Python + SqlAlchemy versions (1.3, 1.4, 2.0) (PHOENIX-6892)
+- Replace deprecated failUnless methods in tests (PHOENIX-6892)
+

Review Comment:
   Could you add here other tickets that are done after 1.2.1
   [PHOENIX-6810](https://github.com/apache/phoenix-queryserver/commit/4b22faa55b5e35974951cc7f41b7e84eeba261dd) , PHOENIX-6861, PHOENIX-6908



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix-queryserver] stoty commented on a diff in pull request #122: PHOENIX-6892 Add support for SqlAlchemy 2.0

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #122:
URL: https://github.com/apache/phoenix-queryserver/pull/122#discussion_r1142154616


##########
python-phoenixdb/NEWS.rst:
##########
@@ -1,6 +1,17 @@
 Changelog
 =========
 
+Unreleased
+----------
+- Update python-phoenixdb/RELEASING.rst (PHOENIX-6820)
+- Add Python 3.11 to supported languages and update docker test image for phoenixdb (PHOENIX-6858)
+- Document workaround for PhoenixDB 1.2+ not working with Python2 on some systems (PHOENIX-6863)
+- Update install instructions in README.rst (PHOENIX-6812)
+- Add support for SQLAlchemy 2.0 (PHOENIX-6892)
+- SQLAlchemy is no longer an install dependency (PHOENIX-6892)
+- Run tests with all supported Python + SqlAlchemy versions (1.3, 1.4, 2.0) (PHOENIX-6892)
+- Replace deprecated failUnless methods in tests (PHOENIX-6892)
+

Review Comment:
   Those are not relevant to the Python driver, and this changelog is specifically for Python only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix-queryserver] stoty closed pull request #122: PHOENIX-6892 Add support for SqlAlchemy 2.0

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty closed pull request #122: PHOENIX-6892 Add support for SqlAlchemy 2.0
URL: https://github.com/apache/phoenix-queryserver/pull/122


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org