You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/01/16 19:07:10 UTC

Review Request 29968: Request to start Downgrade failed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29968/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.


Bugs: AMBARI-9182
    https://issues.apache.org/jira/browse/AMBARI-9182


Repository: ambari


Description
-------

When performing a downgrade, need to be able to specify ALSO the version that was used to attempt a downgrade.  When specified, that indicates the version to lookup the upgrade pack and apply a downgrade.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9b17b33 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bd06c5f 

Diff: https://reviews.apache.org/r/29968/diff/


Testing
-------

Pending


Thanks,

Nate Cole

Re: Review Request 29968: Request to start Downgrade failed

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29968/#review68447
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/29968/#comment112680>

    minor :
    
    I think this could just be ...
    
        boolean forDowngrade = Boolean.valueOf(forceDowngrade);
        
    ... which accounts for null.


- Tom Beerbower


On Jan. 16, 2015, 6:29 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29968/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 6:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9182
>     https://issues.apache.org/jira/browse/AMBARI-9182
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing a downgrade, need to be able to specify ALSO the version that was used to attempt a downgrade.  When specified, that indicates the version to lookup the upgrade pack and apply a downgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9b17b33 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bd06c5f 
> 
> Diff: https://reviews.apache.org/r/29968/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.155s
> [INFO] Finished at: Fri Jan 16 13:28:39 EST 2015
> [INFO] Final Memory: 31M/341M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 29968: Request to start Downgrade failed

Posted by Nate Cole <nc...@hortonworks.com>.

> On Jan. 16, 2015, 1:44 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 312
> > <https://reviews.apache.org/r/29968/diff/1/?file=823587#file823587line312>
> >
> >     Should forceDowngrade be moved to a "directive" since it's not really part of the payload of a UpgradePack
> 
> Tom Beerbower wrote:
>     Good point.  I agree a directive probably makes sense here.

That means I have to add a resource definition and other shit that I didn't want to bother with at this time.


> On Jan. 16, 2015, 1:44 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 315
> > <https://reviews.apache.org/r/29968/diff/1/?file=823587#file823587line315>
> >
> >     forDowngrade or forceDowngrade?

Using the boolean to check overall if the request is really for a downgrade.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29968/#review68449
-----------------------------------------------------------


On Jan. 16, 2015, 1:29 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29968/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 1:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9182
>     https://issues.apache.org/jira/browse/AMBARI-9182
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing a downgrade, need to be able to specify ALSO the version that was used to attempt a downgrade.  When specified, that indicates the version to lookup the upgrade pack and apply a downgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9b17b33 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bd06c5f 
> 
> Diff: https://reviews.apache.org/r/29968/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.155s
> [INFO] Finished at: Fri Jan 16 13:28:39 EST 2015
> [INFO] Final Memory: 31M/341M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 29968: Request to start Downgrade failed

Posted by Tom Beerbower <tb...@hortonworks.com>.

> On Jan. 16, 2015, 6:44 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 312
> > <https://reviews.apache.org/r/29968/diff/1/?file=823587#file823587line312>
> >
> >     Should forceDowngrade be moved to a "directive" since it's not really part of the payload of a UpgradePack

Good point.  I agree a directive probably makes sense here.


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29968/#review68449
-----------------------------------------------------------


On Jan. 16, 2015, 6:29 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29968/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 6:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9182
>     https://issues.apache.org/jira/browse/AMBARI-9182
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing a downgrade, need to be able to specify ALSO the version that was used to attempt a downgrade.  When specified, that indicates the version to lookup the upgrade pack and apply a downgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9b17b33 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bd06c5f 
> 
> Diff: https://reviews.apache.org/r/29968/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.155s
> [INFO] Finished at: Fri Jan 16 13:28:39 EST 2015
> [INFO] Final Memory: 31M/341M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 29968: Request to start Downgrade failed

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29968/#review68449
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/29968/#comment112685>

    Should forceDowngrade be moved to a "directive" since it's not really part of the payload of a UpgradePack



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/29968/#comment112684>

    forDowngrade or forceDowngrade?


- Jonathan Hurley


On Jan. 16, 2015, 1:29 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29968/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 1:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9182
>     https://issues.apache.org/jira/browse/AMBARI-9182
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing a downgrade, need to be able to specify ALSO the version that was used to attempt a downgrade.  When specified, that indicates the version to lookup the upgrade pack and apply a downgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9b17b33 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bd06c5f 
> 
> Diff: https://reviews.apache.org/r/29968/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.155s
> [INFO] Finished at: Fri Jan 16 13:28:39 EST 2015
> [INFO] Final Memory: 31M/341M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 29968: Request to start Downgrade failed

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29968/#review68443
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Jan. 16, 2015, 6:29 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29968/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 6:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9182
>     https://issues.apache.org/jira/browse/AMBARI-9182
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing a downgrade, need to be able to specify ALSO the version that was used to attempt a downgrade.  When specified, that indicates the version to lookup the upgrade pack and apply a downgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9b17b33 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bd06c5f 
> 
> Diff: https://reviews.apache.org/r/29968/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:47.155s
> [INFO] Finished at: Fri Jan 16 13:28:39 EST 2015
> [INFO] Final Memory: 31M/341M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 29968: Request to start Downgrade failed

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29968/
-----------------------------------------------------------

(Updated Jan. 16, 2015, 1:29 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.


Changes
-------

Update with test results


Bugs: AMBARI-9182
    https://issues.apache.org/jira/browse/AMBARI-9182


Repository: ambari


Description
-------

When performing a downgrade, need to be able to specify ALSO the version that was used to attempt a downgrade.  When specified, that indicates the version to lookup the upgrade pack and apply a downgrade.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9b17b33 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bd06c5f 

Diff: https://reviews.apache.org/r/29968/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:47.155s
[INFO] Finished at: Fri Jan 16 13:28:39 EST 2015
[INFO] Final Memory: 31M/341M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole