You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/01/19 18:31:23 UTC
[GitHub] couchdb-fauxton pull request: always update api url
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/616
always update api url
also update api url when routes are in the same route object.
steps to reproduce:
1. click on api bar in _find area for mango
2. click edit
3. click api bar button on _index page
4. url should point to _index
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton update-api-url
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/616.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #616
----
commit 4c25810d085a91505bfc05c2aafbf9f15a55de5f
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-01-19T17:31:55Z
always update api url
also update api url when routes are in the same route object.
steps to reproduce:
1. click on api bar in _find area for mango
2. click edit
3. click api bar button on _index page
4. url should point to _index
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: always update api url
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/616#issuecomment-173130047
merged as 0a03e2e1a600fcd6af27bcb96fcf0bf3bc643236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: always update api url
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/616#issuecomment-173005273
Bit scary - we have a load of legacy logic for updating the API Bar all over the place. But I couldn't find any regression issues, it fixes the issue you noted & seems very sensible. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: always update api url
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/616
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---