[PR] Add a Working with parameters page and link it from the related pages fixes. #2517 (hop)

["Adalennis (via GitHub)" <gi...@apache.org>]

Adalennis opened a new pull request, #9002:
URL: https://github.com/apache/hop/pull/9002

   Fixes #2517
   
   Passing parameters to a child is documented since #8101 (Passing parameters to a child pipeline or workflow). This adds the rest of the issue: how to declare a parameter and give it a value.
   
   - New page Variables › Working with parameters: declare a parameter, use it, and give it a value from Hop Gui (the Run Options dialog), from hop-run (-p) or from another pipeline or workflow (linking to the parameter-passing rules).
   - Links to it from the properties, run, hop-run, variables, fields-parameters-variables and parameter-passing pages.
   - variables.adoc: a project variable wins over an environment variable of the same name (Project.modifyVariables applies the project variables last).
   
   
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
   - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add a Working with parameters page and link it from the related pages fixes. #2517 (hop)

["bamaer (via GitHub)" <gi...@apache.org>]

bamaer merged PR #9002:
URL: https://github.com/apache/hop/pull/9002


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add a Working with parameters page and link it from the related pages fixes. #2517 (hop)

["bamaer (via GitHub)" <gi...@apache.org>]

bamaer commented on PR #9002:
URL: https://github.com/apache/hop/pull/9002#issuecomment-6249475771

   Thanks @Adalennis, this fills the gap from #2517 nicely. I checked the page against the code and ran the hop-run cases, and found one small inaccuracy.
   
   **Worth fixing**
   
   - `variables/parameters.adoc`, "From hop-run": `-p INPUT_FILE=` doesn't fall back to step 2. The empty value replaces the variable's value, so the parameter gets its default value. With a parameter `P` (default `def`), `-s P=sys` gives `sys`, but `-p P= -s P=sys` gives `def`. Suggested wording: drop "An empty value … counts as no value" from step 1 and add after the list: "An empty value, like `-p INPUT_FILE=`, gives the parameter its default value, even when a variable with the same name exists."
   
   Code and docs reviewed; hop-run cases run on a local 2.20.0-SNAPSHOT build. Antora site not built.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add a Working with parameters page and link it from the related pages fixes. #2517 (hop)

["Adalennis (via GitHub)" <gi...@apache.org>]

Adalennis commented on PR #9002:
URL: https://github.com/apache/hop/pull/9002#issuecomment-6250234974

   Thanks @bamaer, you're right: an empty -p value overrides the same-named variable instead of falling back to it. I had only tested -p P= without a variable, where both readings give the default. Fixed with your wording, and checked: -s P=sys gives sys, -p P= -s P=sys gives the default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org