You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Márton Salomváry (JIRA)" <ji...@apache.org> on 2009/06/04 10:57:07 UTC
[jira] Created: (SHINDIG-1077) parsing OpenSocial Templates markup
in gadgets without enabled opensocial-templates feature?
parsing OpenSocial Templates markup in gadgets without enabled opensocial-templates feature?
--------------------------------------------------------------------------------------------
Key: SHINDIG-1077
URL: https://issues.apache.org/jira/browse/SHINDIG-1077
Project: Shindig
Issue Type: Question
Components: Java
Affects Versions: trunk
Reporter: Márton Salomváry
Priority: Minor
SocialMarkupHtmlParser shouldn't parse <script type="text/os-template"> content if <Require feature="opensocial-templates"> is not present in gadget xml.
Otherwise it might break backward compatibility with alternative javascript template implementations, eg: http://ostemplates-demo.appspot.com/ostemplates.js
Example:
Having this in gadget xml <Content>:
<!DOCTYPE html>
<html>
<head>
<script type="text/os-template" name="foo">
<p>
template in head <br/>
viewer: ${Viewer.id}
</p>
</script>
</head>
<body>
...
results the following output:
...
<script name="foo" type="text/os-template">
</script><BODY><p>
template in head <br>
viewer: ${Viewer.id}
</p>
</BODY>
...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1077) parsing OpenSocial Templates
markup in gadgets without enabled opensocial-templates feature?
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716426#action_12716426 ]
Adam Winer commented on SHINDIG-1077:
-------------------------------------
SocialMarkupHtmlParser doesn't know what gadget it's parsing for, and uses a cache that could apply to gadgets with and without the feature. Support for external definitions of opensocial templates (ones other than that delivered by Shindig itself) is not a priority, so marking as Will Not Fix. If there's issues in the parser that break the client-side opensocial templates implementation in Shindig, specific bugs for those would be appreciated.
> parsing OpenSocial Templates markup in gadgets without enabled opensocial-templates feature?
> --------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1077
> URL: https://issues.apache.org/jira/browse/SHINDIG-1077
> Project: Shindig
> Issue Type: Question
> Components: Java
> Affects Versions: trunk
> Reporter: Márton Salomváry
> Priority: Minor
>
> SocialMarkupHtmlParser shouldn't parse <script type="text/os-template"> content if <Require feature="opensocial-templates"> is not present in gadget xml.
> Otherwise it might break backward compatibility with alternative javascript template implementations, eg: http://ostemplates-demo.appspot.com/ostemplates.js
> Example:
> Having this in gadget xml <Content>:
> <!DOCTYPE html>
> <html>
> <head>
> <script type="text/os-template" name="foo">
> <p>
> template in head <br/>
> viewer: ${Viewer.id}
> </p>
> </script>
> </head>
> <body>
> ...
> results the following output:
> ...
> <script name="foo" type="text/os-template">
> </script><BODY><p>
> template in head <br>
> viewer: ${Viewer.id}
> </p>
> </BODY>
> ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-1077) parsing OpenSocial Templates markup
in gadgets without enabled opensocial-templates feature?
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer closed SHINDIG-1077.
-------------------------------
Resolution: Won't Fix
> parsing OpenSocial Templates markup in gadgets without enabled opensocial-templates feature?
> --------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1077
> URL: https://issues.apache.org/jira/browse/SHINDIG-1077
> Project: Shindig
> Issue Type: Question
> Components: Java
> Affects Versions: trunk
> Reporter: Márton Salomváry
> Priority: Minor
>
> SocialMarkupHtmlParser shouldn't parse <script type="text/os-template"> content if <Require feature="opensocial-templates"> is not present in gadget xml.
> Otherwise it might break backward compatibility with alternative javascript template implementations, eg: http://ostemplates-demo.appspot.com/ostemplates.js
> Example:
> Having this in gadget xml <Content>:
> <!DOCTYPE html>
> <html>
> <head>
> <script type="text/os-template" name="foo">
> <p>
> template in head <br/>
> viewer: ${Viewer.id}
> </p>
> </script>
> </head>
> <body>
> ...
> results the following output:
> ...
> <script name="foo" type="text/os-template">
> </script><BODY><p>
> template in head <br>
> viewer: ${Viewer.id}
> </p>
> </BODY>
> ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.