You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ma...@apache.org on 2011/05/23 22:12:32 UTC

svn commit: r1126709 - in /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces: renderkit/html/HtmlAjaxBehaviorRenderer.java view/facelets/FaceletViewDeclarationLanguage.java

Author: martinkoci
Date: Mon May 23 20:12:32 2011
New Revision: 1126709

URL: http://svn.apache.org/viewvc?rev=1126709&view=rev
Log:
MYFACES-3130 [PERF] Avoid unnecessary AbstractList$Itr instances

Modified:
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java?rev=1126709&r1=1126708&r2=1126709&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java Mon May 23 20:12:32 2011
@@ -225,7 +225,9 @@ public class HtmlAjaxBehaviorRenderer ex
         retVal.append("{");
 
         boolean first = true;
-        for (String option : options) {
+        
+        for (int i = 0, size = options.size(); i < size; i++) {
+            String option = options.get(i);
             if (option != null && !option.trim().equals(EMPTY)) {
                 if (!first) {
                     retVal.append(COMMA);

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java?rev=1126709&r1=1126708&r2=1126709&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java Mon May 23 20:12:32 2011
@@ -784,8 +784,9 @@ public class FaceletViewDeclarationLangu
             return;
         }
         
-        for (AttachedObjectHandler currentHandler : handlerList)
+        for (int i = 0, size = handlerList.size(); i < size; i++)
         {
+            AttachedObjectHandler currentHandler = handlerList.get(i);
             // In the spec javadoc this variable is referred as forAttributeValue, but
             // note it is also called curTargetName
             String forValue = currentHandler.getFor();
@@ -845,8 +846,10 @@ public class FaceletViewDeclarationLangu
                     if ( (eventName != null && eventName.equals(currentTarget.getName()) ) || 
                          (eventName == null && isDefaultEvent) )
                     {
-                        for (UIComponent component : currentTarget.getTargets(topLevelComponent))
+                        List<UIComponent> targets = currentTarget.getTargets(topLevelComponent);
+                        for (int j = 0, targetssize = targets.size(); j < targetssize; j++)
                         {
+                            UIComponent component = targets.get(j);
                             // If we found composite components when traverse the tree
                             // we have to call this one recursively, because each composite component
                             // should have its own AttachedObjectHandler list, filled earlier when