You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/16 05:56:49 UTC
Review Request 24765: Added some slave recovery DockerContainerizer
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24765/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/docker_containerizer_tests.cpp 0d7c3b188319768227797d680b0ee8d5f764de10
Diff: https://reviews.apache.org/r/24765/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24765: Added some slave recovery
DockerContainerizer tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 16, 2014, 4:17 p.m., Jie Yu wrote:
> > src/tests/docker_containerizer_tests.cpp, line 1449
> > <https://reviews.apache.org/r/24765/diff/2/?file=662118#file662118line1449>
> >
> > I don't see it being DISABLED?
Oops, forgot to update the review.
> On Aug. 16, 2014, 4:17 p.m., Jie Yu wrote:
> > src/tests/docker_containerizer_tests.cpp, lines 1550-1573
> > <https://reviews.apache.org/r/24765/diff/2/?file=662118#file662118line1550>
> >
> > Instead of doing that in this way, I'm wondering can you do FUTURE_DISPATCH(slave, Slave::executorLaunched)?
YES! Great idea Jie! Soooo much better. Thank you!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24765/#review50822
-----------------------------------------------------------
On Aug. 16, 2014, 2:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24765/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 2:57 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp 0d7c3b188319768227797d680b0ee8d5f764de10
>
> Diff: https://reviews.apache.org/r/24765/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24765: Added some slave recovery
DockerContainerizer tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24765/#review50822
-----------------------------------------------------------
Ship it!
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/24765/#comment88682>
I don't see it being DISABLED?
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/24765/#comment88681>
Instead of doing that in this way, I'm wondering can you do FUTURE_DISPATCH(slave, Slave::executorLaunched)?
- Jie Yu
On Aug. 16, 2014, 2:57 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24765/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 2:57 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp 0d7c3b188319768227797d680b0ee8d5f764de10
>
> Diff: https://reviews.apache.org/r/24765/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24765: Added some slave recovery
DockerContainerizer tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24765/
-----------------------------------------------------------
(Updated Aug. 16, 2014, 2:57 p.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/tests/docker_containerizer_tests.cpp 0d7c3b188319768227797d680b0ee8d5f764de10
Diff: https://reviews.apache.org/r/24765/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman