DO NOT REPLY [Bug 52206] [PATCH] Small performance improvements by adding static declarations

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=52206

--- Comment #1 from Vincent Hennebert <vh...@gmail.com> 2011-11-21 15:51:44 UTC ---
Hi Alexis,

Thanks for your patch. Just a question about the removal of traces: surely if
you disable trace logging there shouldn't be any impact on performance? And if
you worry about performance, you would probably disable low-level loggings
anyway? Or did I miss something?

(In reply to comment #0)
> Created attachment 27967 [details]
> Patch adding static declarations and removing 2 trace messages
> 
> I was profiling an application running FOP 1.0 and found a few hotspots. Some
> of them have been already fixed in trunk ( e.g. Bug 50626 ). 
> 
> The ones requiring minimal changes are contained in this patch. It adds the
> 'static' declaration for loggers and removes 2 heavily used trace logging
> messages. I avoided to include bigger changes (mainly in FObj which would
> benefit by using a LinkedList instead of the siblings array) as bigger patches
> seem to be difficult to process ( #46962 )

Yes it takes too much time to process patches. Please don't give up though,
we'll try to improve...

Thanks,
Vincent

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.