You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "csun5285 (via GitHub)" <gi...@apache.org> on 2026/05/20 10:42:39 UTC

[PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

csun5285 opened a new pull request, #63448:
URL: https://github.com/apache/doris/pull/63448

   The fixture covers every type whose SerDe implements write_one_cell_to_jsonb: all integer / float scalars, DATE, DATETIME, DATEV2, DATETIMEV2, TIMESTAMPTZ, TIMEV2, IPV4, IPV6, STRING, VARCHAR, CHAR, JSONB, DECIMALV2/32/64/128I/256, BITMAP, HLL, QUANTILE_STATE, ARRAY<INT>, MAP<STRING,STRING>, STRUCT<INT,STRING>, VARIANT, and Nullable<INT/STRING/BITMAP>.
   
   The CHAR  assertions also pin down that block_to_jsonb is a pure byte passthrough — decoded cell lengths must equal the originally written lengths, NOT the schema-declared CHAR(8) capacity.
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4498499235

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 171296 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 3155f6c3096d3caca6d9b1873850beded8c30499, data reload: false
   
   query5	4313	666	533	533
   query6	331	224	201	201
   query7	4240	578	314	314
   query8	330	229	222	222
   query9	8829	4056	4062	4056
   query10	454	333	297	297
   query11	5850	2455	2207	2207
   query12	187	138	128	128
   query13	1324	613	419	419
   query14	5975	5347	5078	5078
   query14_1	4397	4417	4409	4409
   query15	222	208	181	181
   query16	1009	459	443	443
   query17	1033	733	591	591
   query18	2502	486	359	359
   query19	221	207	176	176
   query20	144	134	132	132
   query21	221	152	120	120
   query22	13740	13679	13478	13478
   query23	17196	16472	16103	16103
   query23_1	16206	16245	16264	16245
   query24	7411	1805	1294	1294
   query24_1	1309	1319	1303	1303
   query25	597	503	450	450
   query26	1311	325	179	179
   query27	2674	548	336	336
   query28	4474	1967	1980	1967
   query29	1022	667	556	556
   query30	308	237	202	202
   query31	1117	1074	942	942
   query32	101	78	77	77
   query33	548	369	319	319
   query34	1172	1187	653	653
   query35	778	800	688	688
   query36	1350	1350	1205	1205
   query37	159	114	91	91
   query38	3197	3136	3092	3092
   query39	932	931	915	915
   query39_1	862	886	892	886
   query40	235	152	135	135
   query41	74	74	70	70
   query42	115	113	114	113
   query43	338	346	296	296
   query44	
   query45	222	207	200	200
   query46	1088	1222	759	759
   query47	2323	2396	2103	2103
   query48	410	426	300	300
   query49	656	512	404	404
   query50	1046	370	278	278
   query51	4430	4352	4286	4286
   query52	110	116	98	98
   query53	269	306	214	214
   query54	340	312	279	279
   query55	97	95	92	92
   query56	314	343	329	329
   query57	1420	1393	1324	1324
   query58	310	282	271	271
   query59	1581	1641	1497	1497
   query60	336	392	307	307
   query61	157	145	155	145
   query62	667	626	561	561
   query63	247	208	213	208
   query64	2429	818	649	649
   query65	
   query66	1749	503	353	353
   query67	29431	29993	29908	29908
   query68	
   query69	465	357	313	313
   query70	997	1013	1005	1005
   query71	307	283	270	270
   query72	3005	2731	2426	2426
   query73	845	781	438	438
   query74	5112	4920	4744	4744
   query75	2694	2582	2273	2273
   query76	2306	1166	776	776
   query77	412	430	340	340
   query78	12020	12176	11643	11643
   query79	1471	1065	784	784
   query80	1236	533	457	457
   query81	509	280	239	239
   query82	1354	164	128	128
   query83	358	282	249	249
   query84	297	143	112	112
   query85	919	598	460	460
   query86	460	326	332	326
   query87	3539	3371	3240	3240
   query88	3556	2670	2683	2670
   query89	457	394	345	345
   query90	1791	193	177	177
   query91	178	169	160	160
   query92	83	85	84	84
   query93	1570	1568	859	859
   query94	649	355	300	300
   query95	677	396	353	353
   query96	1037	852	322	322
   query97	2730	2672	2549	2549
   query98	239	237	239	237
   query99	1121	1090	983	983
   Total cold run time: 253849 ms
   Total hot run time: 171296 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4506287079

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63448_3155f6c3096d3caca6d9b1873850beded8c30499_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63448_3155f6c3096d3caca6d9b1873850beded8c30499_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.58% (27914/37938) |
   | Line Coverage     | 57.59% (303116/526303) |
   | Region Coverage   | 54.84% (254055/463288) |
   | Branch Coverage   | 56.25% (109558/194785) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4498188303

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4497933242

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31270 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8365f8108f9ef999895fd05c03026fcf47389930, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17821	3906	3819	3819
   q2	q3	10793	1386	790	790
   q4	4684	470	341	341
   q5	7597	2239	2114	2114
   q6	257	174	139	139
   q7	940	771	647	647
   q8	9398	1702	1577	1577
   q9	6617	4905	4891	4891
   q10	6434	2134	1814	1814
   q11	442	268	246	246
   q12	691	430	301	301
   q13	18225	3377	2823	2823
   q14	266	258	239	239
   q15	q16	827	782	706	706
   q17	1005	971	928	928
   q18	6931	5833	5467	5467
   q19	1189	1279	1197	1197
   q20	547	445	286	286
   q21	6046	2682	2626	2626
   q22	455	368	319	319
   Total cold run time: 101165 ms
   Total hot run time: 31270 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4642	4537	4699	4537
   q2	q3	4862	5284	4702	4702
   q4	2146	2182	1432	1432
   q5	4910	4767	4652	4652
   q6	240	186	134	134
   q7	1819	1717	1550	1550
   q8	2338	1915	1901	1901
   q9	7258	7210	7216	7210
   q10	4501	4385	3948	3948
   q11	534	405	349	349
   q12	714	727	509	509
   q13	2971	3421	2806	2806
   q14	279	292	262	262
   q15	q16	681	703	601	601
   q17	1257	1222	1217	1217
   q18	7249	6969	6731	6731
   q19	1154	1121	1086	1086
   q20	2234	2223	1945	1945
   q21	5299	4575	4448	4448
   q22	513	457	398	398
   Total cold run time: 55601 ms
   Total hot run time: 50418 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4497533523

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen merged PR #63448:
URL: https://github.com/apache/doris/pull/63448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4499352306

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63448_3155f6c3096d3caca6d9b1873850beded8c30499_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63448_3155f6c3096d3caca6d9b1873850beded8c30499_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.63% (27932/37938) |
   | Line Coverage     | 57.63% (303319/526303) |
   | Region Coverage   | 54.84% (254075/463288) |
   | Branch Coverage   | 56.34% (109737/194785) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4498411296

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31057 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 3155f6c3096d3caca6d9b1873850beded8c30499, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17753	3907	4012	3907
   q2	q3	10808	1383	817	817
   q4	4679	475	354	354
   q5	7571	2276	2080	2080
   q6	283	183	143	143
   q7	967	767	646	646
   q8	9349	1724	1627	1627
   q9	6422	4928	4823	4823
   q10	6455	2105	1774	1774
   q11	447	278	239	239
   q12	695	427	312	312
   q13	18164	3353	2789	2789
   q14	269	253	233	233
   q15	q16	827	766	712	712
   q17	888	947	883	883
   q18	7006	5682	5628	5628
   q19	1172	1265	1085	1085
   q20	529	403	261	261
   q21	5713	2649	2440	2440
   q22	444	359	304	304
   Total cold run time: 100441 ms
   Total hot run time: 31057 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4243	4208	4194	4194
   q2	q3	4552	4911	4336	4336
   q4	2102	2204	1402	1402
   q5	4399	4238	4265	4238
   q6	230	178	136	136
   q7	2297	1926	1666	1666
   q8	2522	2158	2058	2058
   q9	7806	7923	7896	7896
   q10	4595	4724	4183	4183
   q11	602	424	397	397
   q12	745	726	576	576
   q13	3393	3619	2959	2959
   q14	323	302	287	287
   q15	q16	715	736	674	674
   q17	1347	1306	1294	1294
   q18	7812	7293	7174	7174
   q19	1103	1099	1069	1069
   q20	2219	2260	1942	1942
   q21	5361	4701	4459	4459
   q22	513	463	437	437
   Total cold run time: 56879 ms
   Total hot run time: 51377 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4506194724

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4498015275

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 169210 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8365f8108f9ef999895fd05c03026fcf47389930, data reload: false
   
   query5	4314	659	515	515
   query6	330	232	212	212
   query7	4238	590	313	313
   query8	341	233	227	227
   query9	8815	3957	3969	3957
   query10	472	344	306	306
   query11	5796	2424	2206	2206
   query12	182	130	125	125
   query13	1316	625	444	444
   query14	5955	5360	5048	5048
   query14_1	4445	4400	4364	4364
   query15	210	207	190	190
   query16	1021	458	442	442
   query17	1156	745	613	613
   query18	2774	491	368	368
   query19	220	210	169	169
   query20	142	134	133	133
   query21	221	143	122	122
   query22	13634	13630	13329	13329
   query23	17123	16441	16113	16113
   query23_1	16282	16149	16265	16149
   query24	7413	1751	1324	1324
   query24_1	1309	1278	1323	1278
   query25	569	504	448	448
   query26	1308	323	178	178
   query27	2693	542	340	340
   query28	4422	1996	1977	1977
   query29	1025	631	515	515
   query30	310	239	198	198
   query31	1120	1067	934	934
   query32	89	116	71	71
   query33	521	354	288	288
   query34	1181	1155	652	652
   query35	751	799	666	666
   query36	1335	1320	1161	1161
   query37	152	105	88	88
   query38	3218	3145	3086	3086
   query39	934	915	916	915
   query39_1	888	886	870	870
   query40	227	142	124	124
   query41	66	63	61	61
   query42	115	108	110	108
   query43	322	322	287	287
   query44	
   query45	227	204	205	204
   query46	1120	1168	724	724
   query47	2299	2330	2194	2194
   query48	425	449	303	303
   query49	642	495	382	382
   query50	1055	356	265	265
   query51	4307	4298	4256	4256
   query52	110	104	94	94
   query53	253	281	216	216
   query54	318	299	289	289
   query55	92	89	82	82
   query56	309	299	305	299
   query57	1408	1391	1303	1303
   query58	302	267	264	264
   query59	1497	1618	1387	1387
   query60	315	317	307	307
   query61	160	148	156	148
   query62	666	624	573	573
   query63	241	200	204	200
   query64	2386	806	630	630
   query65	
   query66	1668	480	361	361
   query67	29403	29992	29948	29948
   query68	
   query69	448	324	300	300
   query70	1025	945	992	945
   query71	313	272	268	268
   query72	2957	2694	2414	2414
   query73	813	768	462	462
   query74	5067	4947	4726	4726
   query75	2661	2596	2242	2242
   query76	2297	1145	735	735
   query77	388	388	330	330
   query78	12158	12143	11559	11559
   query79	1465	1035	704	704
   query80	655	543	451	451
   query81	462	287	240	240
   query82	1332	155	127	127
   query83	336	277	247	247
   query84	261	140	114	114
   query85	877	542	450	450
   query86	390	336	298	298
   query87	3385	3488	3214	3214
   query88	3497	2660	2659	2659
   query89	442	387	337	337
   query90	1963	185	179	179
   query91	178	170	139	139
   query92	80	80	72	72
   query93	1475	1445	876	876
   query94	537	345	334	334
   query95	674	471	343	343
   query96	985	788	336	336
   query97	2716	2729	2568	2568
   query98	233	226	234	226
   query99	1070	1102	966	966
   Total cold run time: 252323 ms
   Total hot run time: 169210 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4506194202

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4497524575

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [test](be) add JsonbSerializeUtil::block_to_jsonb golden-file UT covering all row-store-supported types [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #63448:
URL: https://github.com/apache/doris/pull/63448#issuecomment-4506770085

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org