You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "V.Narayanan (JIRA)" <ji...@apache.org> on 2008/02/23 12:29:19 UTC
[jira] Created: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
-----------------------------------------------------------------------------------------------------
Key: DERBY-3455
URL: https://issues.apache.org/jira/browse/DERBY-3455
Project: Derby
Issue Type: Bug
Components: Replication
Affects Versions: 10.4.0.0
Reporter: V.Narayanan
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-3455:
-------------------------------
Attachment: Derby3455.stat
Derby3455.diff
The attached patch moves the replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database.
The methods could all be converted to throw StandardException
instead of SQLException. But this introduces changes to a number of
other files also which I feel can be done at a later stage probably as
a follow-up to this issue or as a seperate issue.
I ran the basic replication steps, startslave, startmaster, failover and it
worked fine.
I request for this patch to be please considered for a commit.
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: Derby3455.diff, Derby3455.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572850#action_12572850 ]
V.Narayanan commented on DERBY-3455:
------------------------------------
Thank you for the review and commit Oystein.
I will submit a follow-up patch for this issue!
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: Derby3455.diff, Derby3455.stat, Derby3455_v2.diff, Derby3455_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan resolved DERBY-3455.
--------------------------------
Resolution: Fixed
Fix Version/s: 10.4.0.0
I have raised Derby-3600 to address the follow-up mentioned here.
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.4.0.0
>
> Attachments: Derby3455.diff, Derby3455.stat, Derby3455_v2.diff, Derby3455_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571722#action_12571722 ]
V.Narayanan commented on DERBY-3455:
------------------------------------
As part of the comments in Derby-3428 the following was said by Jorgen -
I am a little concerned that StandardException has to be introduced to the o.a.d.database.Database interface. I read the comments in that file a couple of times, and it seems that this interface is for methods that are external, like system procedures. I think o.a.d.iapi.db.Database would be more fitting since failover can only be called intarnally (hence i(nternal)api). This does not only apply to the failover method, but to all the replication methods.
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan reassigned DERBY-3455:
----------------------------------
Assignee: V.Narayanan
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-3455:
-------------------------------
Derby Info: [Patch Available]
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: Derby3455.diff, Derby3455.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-3455:
-----------------------------------
Derby Info: (was: [Patch Available])
Committed patch, Derby3455_v2.diff, as revision 631527.
I hope there will be a follow-up patch that unwraps the SQLExcpetions into
StandardException for these methods.
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: Derby3455.diff, Derby3455.stat, Derby3455_v2.diff, Derby3455_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572093#action_12572093 ]
Øystein Grøvlen commented on DERBY-3455:
----------------------------------------
Thanks for the patch. Can you regenerate the patch since the last commit on DERBY-3205 added a method that should also be moved.
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: Derby3455.diff, Derby3455.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3455) Move replication methods from
org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-3455:
-------------------------------
Attachment: Derby3455_v2.stat
Derby3455_v2.diff
Includes the method isInSlaveMode() among the moved methods. I modified the javadoc
of isInSlaveMode() to what I think is right.
Nit Picking: The javadoc for the isInSlaveMode() was not right. The description
part of the javadoc should mention what the method is used for and
the @return tag should mention what the return values are.
I generally find the following page useful when I am doubtful about how
to write javadoc
http://java.sun.com/j2se/javadoc/writingdoccomments/
> Move replication methods from org.apache.derby.database.Database to org.apache.derby.iapi.db.Database
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3455
> URL: https://issues.apache.org/jira/browse/DERBY-3455
> Project: Derby
> Issue Type: Bug
> Components: Replication
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: Derby3455.diff, Derby3455.stat, Derby3455_v2.diff, Derby3455_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.