You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2013/12/02 01:34:14 UTC

[Bug 55833] New: mod_disk_cache reads from closed files

https://issues.apache.org/bugzilla/show_bug.cgi?id=55833

            Bug ID: 55833
           Summary: mod_disk_cache reads from closed files
           Product: Apache httpd-2
           Version: 2.4.6
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_cache_disk / mod_disk_cache
          Assignee: bugs@httpd.apache.org
          Reporter: covener@gmail.com

mod_disk_cache reads and closes hdrs.fd in recall_headers() but clearly closes
hdrs.fd in open_entity (the immediately preceding callback).

On unix, the read from the closed file seems to be tolerated because they are
open with buffering, but I think this is not intended.

IIUC, hdrs.fd should be left open from branches that return OK, and closed on
the others.  Or the relatively short data should be buffered explicitly
somewhere in memory / mod_disk_cache.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 55833] mod_disk_cache reads from closed files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55833

--- Comment #1 from Eric Covener <co...@gmail.com> ---
Created attachment 31087
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31087&action=edit
close headers.fd only when declining open_entity

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 55833] mod_disk_cache reads from closed files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55833

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
                 OS|                            |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 55833] mod_disk_cache reads from closed files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55833

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Christophe JAILLET <ch...@wanadoo.fr> ---
Fixed and released in 2.4.8

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 55833] mod_disk_cache reads from closed files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55833

Eric Covener <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org