You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/10 03:56:35 UTC
[GitHub] [rocketmq-site] tsunghanjacktsai opened a new pull request, #153: Add 02quickstart.md (en)
tsunghanjacktsai opened a new pull request, #153:
URL: https://github.com/apache/rocketmq-site/pull/153
Please do not create a Pull Request without creating an issue first.
## What is the purpose of the change
Add the Quickstart guide English version.
## Brief changelog
1. Add 02quickstart.md English version.
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] caigy commented on a diff in pull request #153: Add 02quickstart.md (en)
Posted by GitBox <gi...@apache.org>.
caigy commented on code in PR #153:
URL: https://github.com/apache/rocketmq-site/pull/153#discussion_r919572789
##########
docs/09-英文/01-Introduction/02quickstart.md:
##########
@@ -0,0 +1,93 @@
+# Quickstart
+
+This section will introduce the method of quickly building and deploying a single-Master RocketMQ cluster to complete simple message sending and receiving.
+
+## 1. Get Apache RocketMQ
+
+:::tip Download RocketMQ
+
+RocketMQ's installation is divided into two types: binary and source. Click [here](https://www.apache.org/dyn/closer.cgi?path=rocketmq/4.9.4/rocketmq-all-4.9.4-source-release.zip) to download Apache RocketMQ 4.9.4 source package, or download the binary package from [here](https://www.apache.org/dyn/closer.cgi?path=rocketmq/4.9.4/rocketmq-all-4.9.4-bin-release.zip). The binary package can be run directly since it has been compiled, and the source package needs to be compiled and run.
Review Comment:
> Great point, but this might need some work in the frontend.
IMO a new issue could be created to achieve it. It's OK for the first version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] ShannonDing merged pull request #153: Add 02quickstart.md (en)
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #153:
URL: https://github.com/apache/rocketmq-site/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] tsunghanjacktsai commented on a diff in pull request #153: Add 02quickstart.md (en)
Posted by GitBox <gi...@apache.org>.
tsunghanjacktsai commented on code in PR #153:
URL: https://github.com/apache/rocketmq-site/pull/153#discussion_r918576556
##########
docs/09-英文/01-Introduction/02quickstart.md:
##########
@@ -0,0 +1,93 @@
+# Quickstart
+
+This section will introduce the method of quickly building and deploying a single-Master RocketMQ cluster to complete simple message sending and receiving.
+
+## 1. Get Apache RocketMQ
+
+:::tip Download RocketMQ
+
+RocketMQ's installation is divided into two types: binary and source. Click [here](https://www.apache.org/dyn/closer.cgi?path=rocketmq/4.9.4/rocketmq-all-4.9.4-source-release.zip) to download Apache RocketMQ 4.9.4 source package, or download the binary package from [here](https://www.apache.org/dyn/closer.cgi?path=rocketmq/4.9.4/rocketmq-all-4.9.4-bin-release.zip). The binary package can be run directly since it has been compiled, and the source package needs to be compiled and run.
Review Comment:
Great point, but this might need some work in the frontend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] tsunghanjacktsai commented on a diff in pull request #153: Add 02quickstart.md (en)
Posted by GitBox <gi...@apache.org>.
tsunghanjacktsai commented on code in PR #153:
URL: https://github.com/apache/rocketmq-site/pull/153#discussion_r918575403
##########
docs/09-英文/01-Introduction/02quickstart.md:
##########
@@ -0,0 +1,93 @@
+# Quickstart
+
+This section will introduce the method of quickly building and deploying a single-Master RocketMQ cluster to complete simple message sending and receiving.
+
+## 1. Get Apache RocketMQ
+
+:::tip Download RocketMQ
Review Comment:
Hey @caigy , these are the syntax for the frontend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-site] caigy commented on a diff in pull request #153: Add 02quickstart.md (en)
Posted by GitBox <gi...@apache.org>.
caigy commented on code in PR #153:
URL: https://github.com/apache/rocketmq-site/pull/153#discussion_r917495107
##########
docs/09-英文/01-Introduction/02quickstart.md:
##########
@@ -0,0 +1,93 @@
+# Quickstart
+
+This section will introduce the method of quickly building and deploying a single-Master RocketMQ cluster to complete simple message sending and receiving.
+
+## 1. Get Apache RocketMQ
+
+:::tip Download RocketMQ
+
+RocketMQ's installation is divided into two types: binary and source. Click [here](https://www.apache.org/dyn/closer.cgi?path=rocketmq/4.9.4/rocketmq-all-4.9.4-source-release.zip) to download Apache RocketMQ 4.9.4 source package, or download the binary package from [here](https://www.apache.org/dyn/closer.cgi?path=rocketmq/4.9.4/rocketmq-all-4.9.4-bin-release.zip). The binary package can be run directly since it has been compiled, and the source package needs to be compiled and run.
Review Comment:
Is there a way to define a global version number to avoid static version number (4.9.4) here?
##########
docs/09-英文/01-Introduction/02quickstart.md:
##########
@@ -0,0 +1,93 @@
+# Quickstart
+
+This section will introduce the method of quickly building and deploying a single-Master RocketMQ cluster to complete simple message sending and receiving.
+
+## 1. Get Apache RocketMQ
+
+:::tip Download RocketMQ
Review Comment:
`:::tip` (as well as `:::` in other place) is still displayed as original text, is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org