[jira] [Commented] (HBASE-9194) Add RPC metrics to metrics2

["Elliott Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737524#comment-13737524 ] 

Elliott Clark commented on HBASE-9194:
--------------------------------------

So you should say that these are all from the master.  And some of them are already supported.  Then most of the rest of them aren't worth the effort to put in.  

* Who is ever going to want to know how long it took to shutdown a master ? (keeping in mind that this isn't stored or sent anywhere before shutdown).  
* There was a lot of cruft that was never used in there: getHServerInfo_avg_time, getProtocolVersion, getProtocolSignature. 
* we don't have row locks anymore.  So you don't want to ask for those metrics.

Check out: Hadoop:service=HBase,name=IPC,sub=IPC

for these:
{code}
rpc.rpc.NumOpenConnections
rpc.rpc.ReceivedBytes
rpc.rpc.RpcProcessingTimeAvgTime
rpc.rpc.RpcProcessingTimeNumOps
rpc.rpc.RpcQueueTimeAvgTime
rpc.rpc.RpcQueueTimeNumOps
{code}

and these:
{code}
rpc.rpc.rpcAuthenticationFailures
rpc.rpc.rpcAuthenticationSuccesses
rpc.rpc.rpcAuthorizationFailures
rpc.rpc.RpcAuthorizationSuccesses
{code}

There are already metrics on compaction in the region server.

So overall I disagree with 90%+ of your list.  Adding metrics for AssignmentManager and Balancer, create table, disable, and drop sure.
                
> Add RPC metrics to metrics2
> ---------------------------
>
>                 Key: HBASE-9194
>                 URL: https://issues.apache.org/jira/browse/HBASE-9194
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>
> The following metrics are supported by 0.94.x:
> {code}
> rpc.rpc.NumOpenConnections
> rpc.rpc.ReceivedBytes
> rpc.rpc.RpcProcessingTimeAvgTime
> rpc.rpc.RpcProcessingTimeNumOps
> rpc.rpc.RpcQueueTimeAvgTime
> rpc.rpc.RpcQueueTimeNumOps
> rpc.rpc.RpcSlowResponse_avg_time
> rpc.rpc.RpcSlowResponse_num_ops
> rpc.rpc.SentBytes
> rpc.rpc.addColumn.aboveOneSec._avg_time
> rpc.rpc.addColumn.aboveOneSec._num_ops
> rpc.rpc.addColumn_avg_time
> rpc.rpc.addColumn_num_ops
> rpc.rpc.assign.aboveOneSec._avg_time
> rpc.rpc.assign.aboveOneSec._num_ops
> rpc.rpc.assign_avg_time
> rpc.rpc.assign_num_ops
> rpc.rpc.balance.aboveOneSec._avg_time
> rpc.rpc.balance.aboveOneSec._num_ops
> rpc.rpc.balanceSwitch.aboveOneSec._avg_time
> rpc.rpc.balanceSwitch.aboveOneSec._num_ops
> rpc.rpc.balanceSwitch_avg_time
> rpc.rpc.balanceSwitch_num_ops
> rpc.rpc.balance_avg_time
> rpc.rpc.balance_num_ops
> rpc.rpc.bulkLoadHFiles_avg_time
> rpc.rpc.bulkLoadHFiles_num_ops
> rpc.rpc.callQueueLen
> rpc.rpc.checkAndDelete_avg_time
> rpc.rpc.checkAndDelete_num_ops
> rpc.rpc.checkAndPut_avg_time
> rpc.rpc.checkAndPut_num_ops
> rpc.rpc.closeRegion_avg_time
> rpc.rpc.closeRegion_num_ops
> rpc.rpc.close_avg_time
> rpc.rpc.close_num_ops
> rpc.rpc.compactRegion_avg_time
> rpc.rpc.compactRegion_num_ops
> rpc.rpc.createTable.aboveOneSec._avg_time
> rpc.rpc.createTable.aboveOneSec._num_ops
> rpc.rpc.createTable_avg_time
> rpc.rpc.createTable_num_ops
> rpc.rpc.deleteColumn.aboveOneSec._avg_time
> rpc.rpc.deleteColumn.aboveOneSec._num_ops
> rpc.rpc.deleteColumn_avg_time
> rpc.rpc.deleteColumn_num_ops
> rpc.rpc.deleteTable.aboveOneSec._avg_time
> rpc.rpc.deleteTable.aboveOneSec._num_ops
> rpc.rpc.deleteTable_avg_time
> rpc.rpc.deleteTable_num_ops
> rpc.rpc.delete_avg_time
> rpc.rpc.delete_num_ops
> rpc.rpc.disableTable.aboveOneSec._avg_time
> rpc.rpc.disableTable.aboveOneSec._num_ops
> rpc.rpc.disableTable_avg_time
> rpc.rpc.disableTable_num_ops
> rpc.rpc.enableTable.aboveOneSec._avg_time
> rpc.rpc.enableTable.aboveOneSec._num_ops
> rpc.rpc.enableTable_avg_time
> rpc.rpc.enableTable_num_ops
> rpc.rpc.execCoprocessor_avg_time
> rpc.rpc.execCoprocessor_num_ops
> rpc.rpc.exists_avg_time
> rpc.rpc.exists_num_ops
> rpc.rpc.flushRegion_avg_time
> rpc.rpc.flushRegion_num_ops
> rpc.rpc.getAlterStatus.aboveOneSec._avg_time
> rpc.rpc.getAlterStatus.aboveOneSec._num_ops
> rpc.rpc.getAlterStatus_avg_time
> rpc.rpc.getAlterStatus_num_ops
> rpc.rpc.getBlockCacheColumnFamilySummaries_avg_time
> rpc.rpc.getBlockCacheColumnFamilySummaries_num_ops
> rpc.rpc.getClosestRowBefore_avg_time
> rpc.rpc.getClosestRowBefore_num_ops
> rpc.rpc.getClusterStatus.aboveOneSec._avg_time
> rpc.rpc.getClusterStatus.aboveOneSec._num_ops
> rpc.rpc.getClusterStatus_avg_time
> rpc.rpc.getClusterStatus_num_ops
> rpc.rpc.getHServerInfo_avg_time
> rpc.rpc.getHServerInfo_num_ops
> rpc.rpc.getHTableDescriptors.aboveOneSec._avg_time
> rpc.rpc.getHTableDescriptors.aboveOneSec._num_ops
> rpc.rpc.getHTableDescriptors_avg_time
> rpc.rpc.getHTableDescriptors_num_ops
> rpc.rpc.getOnlineRegions_avg_time
> rpc.rpc.getOnlineRegions_num_ops
> rpc.rpc.getProtocolSignature.aboveOneSec._avg_time
> rpc.rpc.getProtocolSignature.aboveOneSec._num_ops
> rpc.rpc.getProtocolSignature_avg_time
> rpc.rpc.getProtocolSignature_num_ops
> rpc.rpc.getProtocolVersion.aboveOneSec._avg_time
> rpc.rpc.getProtocolVersion.aboveOneSec._num_ops
> rpc.rpc.getProtocolVersion_avg_time
> rpc.rpc.getProtocolVersion_num_ops
> rpc.rpc.getRegionInfo_avg_time
> rpc.rpc.getRegionInfo_num_ops
> rpc.rpc.get_avg_time
> rpc.rpc.get_num_ops
> rpc.rpc.incrementColumnValue_avg_time
> rpc.rpc.incrementColumnValue_num_ops
> rpc.rpc.increment_avg_time
> rpc.rpc.increment_num_ops
> rpc.rpc.isMasterRunning.aboveOneSec._avg_time
> rpc.rpc.isMasterRunning.aboveOneSec._num_ops
> rpc.rpc.isMasterRunning_avg_time
> rpc.rpc.isMasterRunning_num_ops
> rpc.rpc.lockRow_avg_time
> rpc.rpc.lockRow_num_ops
> rpc.rpc.modifyColumn.aboveOneSec._avg_time
> rpc.rpc.modifyColumn.aboveOneSec._num_ops
> rpc.rpc.modifyColumn_avg_time
> rpc.rpc.modifyColumn_num_ops
> rpc.rpc.modifyTable.aboveOneSec._avg_time
> rpc.rpc.modifyTable.aboveOneSec._num_ops
> rpc.rpc.modifyTable_avg_time
> rpc.rpc.modifyTable_num_ops
> rpc.rpc.move.aboveOneSec._avg_time
> rpc.rpc.move.aboveOneSec._num_ops
> rpc.rpc.move_avg_time
> rpc.rpc.move_num_ops
> rpc.rpc.multi_avg_time
> rpc.rpc.multi_num_ops
> rpc.rpc.next_avg_time
> rpc.rpc.next_num_ops
> rpc.rpc.offline.aboveOneSec._avg_time
> rpc.rpc.offline.aboveOneSec._num_ops
> rpc.rpc.offline_avg_time
> rpc.rpc.offline_num_ops
> rpc.rpc.openRegion_avg_time
> rpc.rpc.openRegion_num_ops
> rpc.rpc.openRegions_avg_time
> rpc.rpc.openRegions_num_ops
> rpc.rpc.openScanner_avg_time
> rpc.rpc.openScanner_num_ops
> rpc.rpc.put_avg_time
> rpc.rpc.put_num_ops
> rpc.rpc.regionServerReport.aboveOneSec._avg_time
> rpc.rpc.regionServerReport.aboveOneSec._num_ops
> rpc.rpc.regionServerReport_avg_time
> rpc.rpc.regionServerReport_num_ops
> rpc.rpc.regionServerStartup.aboveOneSec._avg_time
> rpc.rpc.regionServerStartup.aboveOneSec._num_ops
> rpc.rpc.regionServerStartup_avg_time
> rpc.rpc.regionServerStartup_num_ops
> rpc.rpc.replicateLogEntries_avg_time
> rpc.rpc.replicateLogEntries_num_ops
> rpc.rpc.reportRSFatalError.aboveOneSec._avg_time
> rpc.rpc.reportRSFatalError.aboveOneSec._num_ops
> rpc.rpc.reportRSFatalError_avg_time
> rpc.rpc.reportRSFatalError_num_ops
> rpc.rpc.rollHLogWriter_avg_time
> rpc.rpc.rollHLogWriter_num_ops
> rpc.rpc.rpcAuthenticationFailures
> rpc.rpc.rpcAuthenticationSuccesses
> rpc.rpc.rpcAuthorizationFailures
> rpc.rpc.RpcAuthorizationSuccesses
> rpc.rpc.shutdown.aboveOneSec._avg_time
> rpc.rpc.shutdown.aboveOneSec._num_ops
> rpc.rpc.shutdown_avg_time
> rpc.rpc.shutdown_num_ops
> rpc.rpc.splitRegion_avg_time
> rpc.rpc.splitRegion_num_ops
> rpc.rpc.stopMaster.aboveOneSec._avg_time
> rpc.rpc.stopMaster.aboveOneSec._num_ops
> rpc.rpc.stopMaster_avg_time
> rpc.rpc.stopMaster_num_ops
> rpc.rpc.stop_avg_time
> rpc.rpc.stop_num_ops
> rpc.rpc.unassign.aboveOneSec._avg_time
> rpc.rpc.unassign.aboveOneSec._num_ops
> rpc.rpc.unassign_avg_time
> rpc.rpc.unassign_num_ops
> rpc.rpc.unlockRow_avg_time
> rpc.rpc.unlockRow_num_ops
> {code}
> 0.95 / 0.96 should support them as metrics2 metrics

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira