You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/26 09:40:56 UTC

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #183: feat(apisix): add service monitor support

tokers commented on a change in pull request #183:
URL: https://github.com/apache/apisix-helm-chart/pull/183#discussion_r757357047



##########
File path: charts/apisix/templates/configmap.yaml
##########
@@ -226,6 +226,13 @@ data:
 
     {{- if .Values.customPlugins.enabled }}
     plugin_attr:
+      {{- if .Values.serviceMonitor.enabled }}
+      prometheus:
+        export_addr:
+          ip: 0.0.0.0

Review comment:
       It's dangerous and if APISIX instances are exposed to the Internet, the metrics data can be fetched by others.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org