You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "EpsilonPrime (via GitHub)" <gi...@apache.org> on 2024/08/14 02:25:28 UTC

Re: [PR] [CH-191] Support generate exec [incubator-gluten]

EpsilonPrime commented on code in PR #574:
URL: https://github.com/apache/incubator-gluten/pull/574#discussion_r1716232183


##########
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -890,6 +892,17 @@ message Expression {
   }
 }
 
+message GenerateRel {
+  RelCommon common = 1;
+  Rel input = 2;
+  
+  Expression generator = 3;

Review Comment:
   Should this relation be removed in favor of the official Substrait repo's ExpandRel?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org