You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/10 21:28:56 UTC
[GitHub] [incubator-druid] himanshug opened a new pull request #9010:
optionally enable Jetty ForwardedRequestCustomizer
himanshug opened a new pull request #9010: optionally enable Jetty ForwardedRequestCustomizer
URL: https://github.com/apache/incubator-druid/pull/9010
### Description
Adds new configuration `druid.server.http.enableForwardedRequestCustomizer` to optionally add [ForwardedRequestCustomizer](https://www.eclipse.org/jetty/javadoc/9.4.22.v20191022/org/eclipse/jetty/server/ForwardedRequestCustomizer.html) to Jetty Connector. It is to be used when Druid is behind a proxy for whatever reason, for example proxy is doing TLS termination. In that case Druid receives a HTTP request and `request.getScheme()` returns `http` so any redirects are not done to `https` . Proxy sends `X-Forwarded-*` headers to provide true source information including the scheme and is handled correctly in the Druid jetty server when above configuration is enabled.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
* `JettyServerModule`
* `ServerConfig`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org