You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/01/26 02:22:52 UTC
Review Request 69843: Track operations on agent default resources in
master state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69843/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón Kleiman.
Bugs: MESOS-9471
https://issues.apache.org/jira/browse/MESOS-9471
Repository: mesos
Description
-------
This patch updates the master to add operations on agent
default resources to its in-memory state upon receipt of
UpdateSlaveMessages.
Diffs
-----
src/master/master.cpp 2e0a0de4d745112011370741b8cedbb6db17b915
src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
Diff: https://reviews.apache.org/r/69843/diff/1/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*OperationUpdateDuringFailover*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 69843: Track operations on agent default resources
in master state.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69843/#review212358
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69790', '69791', '69792', '69793', '69794', '69795', '69825', '69843']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2820/mesos-review-69843
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2820/mesos-review-69843/logs/mesos-tests.log):
```
I0126 03:35:24.911964 18592 master.cpp:11301] Removing task f76dc7f6-3df5-4ab7-89cd-7c8e157a6ce5 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 0642b521-7903-4640-b072-b1f29c0e606a-0000 on agent 0642b521-7903-4640-b072-b1f29c0e606a-S0 at slave(473)@192.10.1.6:65031 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0126 03:35:24.915967 18592 master.cpp:1269] Agent 0642b521-7903-4640-b072-b1f29c0e606a-S0 at slave(473)@192.10.1.6:65031 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0126 03:35:24.915967 18592 master.cpp:3272] Disconnecting agent 0642b521-7903-4640-b072-b1f29c0e606a-S0 at slave(473)@192.10.1.6:65031 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0126 03:35:24.915967 18592 master.cpp:3291] Deactivating agent 0642b521-7903-4640-b072-b1f29c0e606a-S0 at slave(473)@192.10.1.6:65031 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0126 03:35:24.916967 18968 hierarchical.cpp:358] Removed framework 0642b521-7903-4640-b072-b1f29c0e606a-0000
I0126 03:35:24.916967 18968 hierarchical.cpp:793] Agent 0642b521-7903-4640-b072-b1f29c0e606a-S0 deactivated
I0126 03:35:24.916967 444 containerizer.cpp:2469] Destroying container d6360819-754c-410f-864f-78c2f4068d1b in RUNNING state
I0126 03:35:24.916967 444 containerizer.cpp:3136] Transitioning the state of container d6360819-754c-410f-864f-78c2f4068d1b from RUNNING to DESTR[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (684 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (702 ms total)
[----------] Global test environment tear-down
[==========] 1090 tests from 104 test cases ran. (538035 ms total)
[ PASSED ] 1089 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
OYING
I0126 03:35:24.917970 444 launcher.cpp:161] Asked to destroy container d6360819-754c-410f-864f-78c2f4068d1b
W0126 03:35:24.918974 20068 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=12876 to peer '192.10.1.6:50562': IO failed with error code: The specified network name is no longer available.
W0126 03:35:24.919975 20068 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=12768 to peer '192.10.1.6:50563': IO failed with error code: The specified network name is no longer available.
I0126 03:35:24.923964 14524 containerizer.cpp:2975] Container d6360819-754c-410f-864f-78c2f4068d1b has exited
I0126 03:35:24.954970 14628 master.cpp:1109] Master terminating
I0126 03:35:24.954970 18628 hierarchical.cpp:644] Removed agent 0642b521-7903-4640-b072-b1f29c0e606a-S0
I0126 03:35:25.314985 20068 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 26, 2019, 2:22 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69843/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2019, 2:22 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón Kleiman.
>
>
> Bugs: MESOS-9471
> https://issues.apache.org/jira/browse/MESOS-9471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master to add operations on agent
> default resources to its in-memory state upon receipt of
> UpdateSlaveMessages.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2e0a0de4d745112011370741b8cedbb6db17b915
> src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
>
>
> Diff: https://reviews.apache.org/r/69843/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*OperationUpdateDuringFailover*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69843: Track operations on agent default resources
in master state.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69843/#review212433
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69786', '69723', '69790', '69791', '69792', '69793', '69794', '69795', '69825', '69851', '69843']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2829/mesos-review-69843
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2829/mesos-review-69843/logs/mesos-tests.log):
```
W0130 00:42:31.749464 23388 slave.cpp:3934] Ignoring shutdown framework f4443635-00b3-40d9-b169-11c709f6a25f-0000 because it is terminating
I0130 00:42:31.751462 16092 master.cpp:1269] Agent f4443635-00b3-40d9-b169-11c709f6a25f-S0 at slave(477)@192.10.1.6:58193 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0130 00:42:31.752456 16092 master.cpp:3272] Disconnecting agent f4443635-00b3-40d9-b169-11c709f6a25f-S0 at slave(477)@192.10.1.6:58193 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0130 00:42:31.752456 16092 master.cpp:3291] Deactivating agent f4443635-00b3-40d9-b169-11c709f6a25f-S0 at slave(477)@192.10.1.6:58193 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0130 00:42:31.752456 10424 hierarchical.cpp:358] Removed framework f4443635-00b3-40d9-b169-11c709f6a25f-0000
I0130 00:42:31.752456 10424 hierarchical.cpp:793] Agent f4443635-00b3-40d9-b169-11c709f6a25f-S0 deactivated
I0130 00:42:31.753477 25528 containerizer.cpp:2477] Destroying container e3e37928-0e93-4a4f-b8aa-6c363e8956cd in RUNNING state
I0130 00:42:31.753477 25528 containerizer.cpp:3144] Transitioning the state of container e3e37928-0e93-4a4f-b8aa-6c363e8956cd from RUNNING to DESTROYING
I0130 00:42:31.754835 25528 launcher.cpp:161] Asked to destroy container e3e37928-0e93-4a4f-b8aa-6c363e8956cd
W0130 00:42:31.755467 24792 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=9276 to peer '192.10.1.6:60086': IO failed with error code: The specified network name [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (688 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)
[----------] Global test environment tear-down
[==========] 1093 tests from 104 test cases ran. (494677 ms total)
[ PASSED ] 1092 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
is no longer available.
W0130 00:42:31.756462 24792 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=9400 to peer '192.10.1.6:60085': IO failed with error code: The specified network name is no longer available.
I0130 00:42:31.840862 22188 containerizer.cpp:2983] Container e3e37928-0e93-4a4f-b8aa-6c363e8956cd has exited
I0130 00:42:31.873888 23388 master.cpp:1109] Master terminating
I0130 00:42:31.874857 25528 hierarchical.cpp:644] Removed agent f4443635-00b3-40d9-b169-11c709f6a25f-S0
I0130 00:42:32.242929 24792 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 29, 2019, 3:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69843/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2019, 3:30 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón Kleiman.
>
>
> Bugs: MESOS-9471
> https://issues.apache.org/jira/browse/MESOS-9471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master to add operations on agent
> default resources to its in-memory state upon receipt of
> UpdateSlaveMessages.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2e0a0de4d745112011370741b8cedbb6db17b915
> src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
>
>
> Diff: https://reviews.apache.org/r/69843/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*OperationUpdateDuringFailover*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69843: Track operations on agent default resources
in master state.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69843/
-----------------------------------------------------------
(Updated Jan. 29, 2019, 11:30 p.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón Kleiman.
Bugs: MESOS-9471
https://issues.apache.org/jira/browse/MESOS-9471
Repository: mesos
Description
-------
This patch updates the master to add operations on agent
default resources to its in-memory state upon receipt of
UpdateSlaveMessages.
Diffs
-----
src/master/master.cpp 2e0a0de4d745112011370741b8cedbb6db17b915
src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
Diff: https://reviews.apache.org/r/69843/diff/1/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*OperationUpdateDuringFailover*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 69843: Track operations on agent default resources
in master state.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69843/#review212429
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Jan. 25, 2019, 6:22 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69843/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2019, 6:22 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón Kleiman.
>
>
> Bugs: MESOS-9471
> https://issues.apache.org/jira/browse/MESOS-9471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master to add operations on agent
> default resources to its in-memory state upon receipt of
> UpdateSlaveMessages.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2e0a0de4d745112011370741b8cedbb6db17b915
> src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28
>
>
> Diff: https://reviews.apache.org/r/69843/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*OperationUpdateDuringFailover*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>