[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1854: fix checkstyle of core-task issue

[GitBox <gi...@apache.org>]

javeme commented on code in PR #1854:
URL: https://github.com/apache/incubator-hugegraph/pull/1854#discussion_r859819260


##########
hugegraph-core/src/main/java/com/baidu/hugegraph/job/computer/AbstractComputer.java:
##########
@@ -117,7 +114,7 @@ public Object call(Job<Object> job, Map<String, Object> parameters) {
             Process process = builder.start();
 
             StringBuilder output = new StringBuilder();
-            try(LineNumberReader reader = new LineNumberReader(
+            try (LineNumberReader reader = new LineNumberReader(

Review Comment:
   also update alignment?



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/security/HugeSecurityManager.java:
##########
@@ -47,10 +47,10 @@ public class HugeSecurityManager extends SecurityManager {
             "org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine"
     );
 
-    private static final Set<String> DENIED_PERMISSIONS = ImmutableSet.of(
-            "setSecurityManager"
-            //"suppressAccessChecks"
-    );
+    //"suppressAccessChecks"

Review Comment:
   expect to add a space after "//"



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/security/HugeSecurityManager.java:
##########
@@ -47,10 +47,10 @@ public class HugeSecurityManager extends SecurityManager {
             "org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine"
     );
 
-    private static final Set<String> DENIED_PERMISSIONS = ImmutableSet.of(
-            "setSecurityManager"
-            //"suppressAccessChecks"
-    );
+    //"suppressAccessChecks"

Review Comment:
   `// TODO: add "suppressAccessChecks"`



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/schema/builder/PropertyKeyBuilder.java:
##########
@@ -69,8 +68,7 @@ public PropertyKeyBuilder(SchemaTransaction transaction,
         this.checkExist = true;
     }
 
-    public PropertyKeyBuilder(SchemaTransaction transaction,
-                              HugeGraph graph, PropertyKey copy) {
+    public PropertyKeyBuilder(SchemaTransaction transaction, HugeGraph graph, PropertyKey copy) {

Review Comment:
   ditto



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/schema/builder/PropertyKeyBuilder.java:
##########
@@ -43,8 +43,7 @@
 import com.baidu.hugegraph.type.define.WriteType;
 import com.baidu.hugegraph.util.E;
 
-public class PropertyKeyBuilder extends AbstractBuilder
-                                implements PropertyKey.Builder {
+public class PropertyKeyBuilder extends AbstractBuilder implements PropertyKey.Builder {

Review Comment:
   can we keep 80 chars as guide line length?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org