You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2011/06/30 11:16:28 UTC

[jira] [Commented] (QPID-3325) Make it possible to access broker shutdown hook from outside

    [ https://issues.apache.org/jira/browse/QPID-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057706#comment-13057706 ] 

Keith Wall commented on QPID-3325:
----------------------------------

Hi Danushka

I've reviewed your patch.

First, I have a question.  For what purpose does calling code require access to the ShutdownServiceThread?  If it is so the calling code can can *unregister* the shutdown hook, then I think it would be better if ApplicationRegistry itself took on this responsibility.  I think ApplicationRegistry should register the shutdown hook on initialisation (initialise()), and remove the shutdown hook when the remove is called (currently remove/removeAll()).

I am currently working in ApplicationRegistry (QPID-3026) and could incorporate this improvement too.  Please let me know your thoughts.  

Kind regards Keith Wall.


 


> Make it possible to access broker shutdown hook from outside
> ------------------------------------------------------------
>
>                 Key: QPID-3325
>                 URL: https://issues.apache.org/jira/browse/QPID-3325
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Danushka Menikkumbura
>            Assignee: Robbie Gemmell
>         Attachments: QPID-3325.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org