[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4468: [Improve][AWS] update the bundle aws sdk version to 1.11.1034

["hailin0 (via GitHub)" <gi...@apache.org>]

hailin0 commented on PR #4468:
URL: https://github.com/apache/incubator-seatunnel/pull/4468#issuecomment-1502090682

   > > Yes, I think `1.11.1034` is good. Please add e2e for this pr.
   > > You can add an e2e test case and run it in your local env. And then put the picture of the result here. Before you push the e2e code, you need add `@Disable` annotation for it.
   > 
   > Sorry I am not very familiar this project code base, how to write e2e testing code? I find several folders in [seatunnel-e2e](https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e) which should I create the testing code class? Or should I pick up a Connector such as S3File to write the testing code?
   reference
   https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org