You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2018/06/12 10:33:33 UTC

Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2132
    https://issues.apache.org/jira/browse/RANGER-2132


Repository: ranger


Description
-------

Add unit tests for org.apache.ranger.common package


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
  security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
  security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
  security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
  security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 


Diff: https://reviews.apache.org/r/67544/diff/1/


Testing
-------

Tested with below two type

1.eclipse->Run as->Junit Test
2.mvn test


Thanks,

bhavik patel


Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/#review204596
-----------------------------------------------------------




security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java
Lines 126 (patched)
<https://reviews.apache.org/r/67544/#comment287175>

    This looks suspicious, is it testing the getPropertyStringList method? If yes, this actualroles = roles will override the result.
    
    You can set the values with 'PropertiesUtil.getPropertiesMap().put(...)'


- Zsombor Gegesy


On June 12, 2018, 10:33 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67544/
> -----------------------------------------------------------
> 
> (Updated June 12, 2018, 10:33 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2132
>     https://issues.apache.org/jira/browse/RANGER-2132
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add unit tests for org.apache.ranger.common package
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
>   security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
>   security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
>   security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
>   security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67544/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with below two type
> 
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/#review204780
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On June 14, 2018, 9:19 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67544/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 9:19 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2132
>     https://issues.apache.org/jira/browse/RANGER-2132
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add unit tests for org.apache.ranger.common package
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
>   security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
>   security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
>   security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
>   security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67544/diff/3/
> 
> 
> Testing
> -------
> 
> Tested with below two type
> 
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/#review204777
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On June 14, 2018, 9:19 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67544/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 9:19 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2132
>     https://issues.apache.org/jira/browse/RANGER-2132
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add unit tests for org.apache.ranger.common package
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
>   security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
>   security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
>   security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
>   security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67544/diff/3/
> 
> 
> Testing
> -------
> 
> Tested with below two type
> 
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/
-----------------------------------------------------------

(Updated June 15, 2018, 1:25 p.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2132
    https://issues.apache.org/jira/browse/RANGER-2132


Repository: ranger


Description
-------

Add unit tests for org.apache.ranger.common package


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
  security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
  security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
  security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
  security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 


Diff: https://reviews.apache.org/r/67544/diff/4/

Changes: https://reviews.apache.org/r/67544/diff/3-4/


Testing
-------

Tested with below two type

1.eclipse->Run as->Junit Test
2.mvn test


Thanks,

bhavik patel


Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/
-----------------------------------------------------------

(Updated June 14, 2018, 9:19 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2132
    https://issues.apache.org/jira/browse/RANGER-2132


Repository: ranger


Description
-------

Add unit tests for org.apache.ranger.common package


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
  security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
  security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
  security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
  security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 


Diff: https://reviews.apache.org/r/67544/diff/3/

Changes: https://reviews.apache.org/r/67544/diff/2-3/


Testing
-------

Tested with below two type

1.eclipse->Run as->Junit Test
2.mvn test


Thanks,

bhavik patel


Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/#review204732
-----------------------------------------------------------




security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java
Lines 733 (patched)
<https://reviews.apache.org/r/67544/#comment287423>

    Fix the compilation error. 
    
    ```
    [INFO] -------------------------------------------------------------
    [ERROR] COMPILATION ERROR :
    [INFO] -------------------------------------------------------------
    [ERROR] /Users/vperiasamy/git/tlp-ranger/master/ranger/security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java:[733,24] error: cannot find symbol
    [INFO] 1 error
    [INFO] -------------------------------------------------------------
    ```


- Velmurugan Periasamy


On June 13, 2018, 10:48 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67544/
> -----------------------------------------------------------
> 
> (Updated June 13, 2018, 10:48 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2132
>     https://issues.apache.org/jira/browse/RANGER-2132
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add unit tests for org.apache.ranger.common package
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
>   security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
>   security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
>   security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
>   security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67544/diff/2/
> 
> 
> Testing
> -------
> 
> Tested with below two type
> 
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/#review204680
-----------------------------------------------------------


Ship it!




Ship It!

- Zsombor Gegesy


On June 13, 2018, 10:48 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67544/
> -----------------------------------------------------------
> 
> (Updated June 13, 2018, 10:48 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2132
>     https://issues.apache.org/jira/browse/RANGER-2132
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add unit tests for org.apache.ranger.common package
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
>   security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
>   security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
>   security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
>   security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
>   security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67544/diff/2/
> 
> 
> Testing
> -------
> 
> Tested with below two type
> 
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Re: Review Request 67544: RANGER-2132 : Add unit tests for org.apache.ranger.common package

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67544/
-----------------------------------------------------------

(Updated June 13, 2018, 10:48 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2132
    https://issues.apache.org/jira/browse/RANGER-2132


Repository: ranger


Description
-------

Add unit tests for org.apache.ranger.common package


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/common/ContextUtil.java 18c8ba8 
  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 0e99be1 
  security-admin/src/test/java/org/apache/ranger/common/TestContextUtil.java PRE-CREATION 
  security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 9d2ef55 
  security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 5b4787d 
  security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java 4fb3a19 
  security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java PRE-CREATION 


Diff: https://reviews.apache.org/r/67544/diff/2/

Changes: https://reviews.apache.org/r/67544/diff/1-2/


Testing
-------

Tested with below two type

1.eclipse->Run as->Junit Test
2.mvn test


Thanks,

bhavik patel