You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/20 22:11:02 UTC

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #9970: [Hexagon] Do not auto-build apps when building TVM

kparzysz-quic commented on a change in pull request #9970:
URL: https://github.com/apache/tvm/pull/9970#discussion_r789189110



##########
File path: apps/hexagon_api/CMakeLists.txt
##########
@@ -0,0 +1,83 @@
+cmake_minimum_required(VERSION 3.2)
+
+project(hexagon_api)
+
+include(ExternalProject)
+
+# Required variables:
+#   ANDROID_ABI
+#   ANDROID_PLATFORM
+#   USE_ANDROID_TOOLCHAIN (Android toolchain .cmake file)
+#   USE_HEXAGON_ARCH
+#   USE_HEXAGON_SDK
+#   USE_HEXAGON_TOOLCHAIN (Path to Hexagon toolchain ending with "Tools")
+
+set(TVM_SOURCE_DIR "${CMAKE_SOURCE_DIR}/../..")
+set(HEXAGON_API_BINARY_DIR "${CMAKE_BINARY_DIR}/hexagon_rpc")

Review comment:
       This is going to be really fragile.  Instead I propose a flag `USE_OUTPUT_BINARY_DIR` that could be set to any location, including `.../build/hexagon_rpc`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org