You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/15 16:42:01 UTC
[GitHub] [flink] slinkydeveloper opened a new pull request #17800: [FLINK-24781] Add to string casting rules
slinkydeveloper opened a new pull request #17800:
URL: https://github.com/apache/flink/pull/17800
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Porting of the to string casting logic to the new `CastRule` stack
## Brief change log
- Added a method in `CastRule` to define explicitly if the rule can fail or not. Then adapted the `ScalarOperatorGens` runtime to make sure `CAST` doesn't fail when the rule can fail (as temporary fix before https://issues.apache.org/jira/browse/FLINK-24385 is worked out)
- Added to string cast rules
* Modified some methods in parsing logic for numerics and dates to make sure they fail when the conversion can't be performed.
## Verifying this change
Added test cases to `CastRulesTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
* 746084b9af7389bab70294dce23bd5d192b5acee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750217474
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ byte result = (byte) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "BYTE", "Overflow");
}
- public static Double toDouble(BinaryStringData str) {
+ public static double toDouble(BinaryStringData str) throws TableException {
try {
- return Double.valueOf(str.toString());
+ return Double.parseDouble(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to DOUBLE", e);
}
}
- public static Float toFloat(BinaryStringData str) {
+ public static float toFloat(BinaryStringData str) throws TableException {
try {
- return Float.valueOf(str.toString());
+ return Float.parseFloat(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to FLOAT", e);
+ }
+ }
+
+ private static TableException numberFormatExceptionFor(
+ StringData input, String targetType, @Nullable String reason) {
+ if (reason == null) {
+ return new TableException(
+ "Cannot parse STRING to " + targetType,
+ new NumberFormatException("For input string: \"" + input + "\""));
+ }
+
+ return new TableException(
+ "Cannot parse STRING to " + targetType,
+ new NumberFormatException("For input string: \"" + input + "\". " + reason));
+ }
+
+ public static int toDate(BinaryStringData str) throws TableException {
+ Integer date = DateTimeUtils.dateStringToUnixDate(str.toString());
+ if (date == null) {
+ throw new TableException("Cannot parse STRING to DATE");
}
+
+ return date;
+ }
+
+ public static int toTime(BinaryStringData str) throws TableException {
+ Integer date = DateTimeUtils.timeStringToUnixDate(str.toString());
+ if (date == null) {
+ throw new TableException("Cannot parse STRING to TIME");
+ }
+
+ return date;
+ }
+
+ public static TimestampData toTimestamp(BinaryStringData str) throws TableException {
+ TimestampData timestamp = DateTimeUtils.toTimestampData(str.toString());
+ if (timestamp == null) {
+ throw new TableException("Cannot parse STRING to TIMESTAMP");
Review comment:
Probably it makes sense to specify what string cannot be parsed like it is done for `toBoolean`.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ byte result = (byte) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "BYTE", "Overflow");
}
- public static Double toDouble(BinaryStringData str) {
+ public static double toDouble(BinaryStringData str) throws TableException {
try {
- return Double.valueOf(str.toString());
+ return Double.parseDouble(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to DOUBLE", e);
}
}
- public static Float toFloat(BinaryStringData str) {
+ public static float toFloat(BinaryStringData str) throws TableException {
try {
- return Float.valueOf(str.toString());
+ return Float.parseFloat(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to FLOAT", e);
+ }
+ }
+
+ private static TableException numberFormatExceptionFor(
+ StringData input, String targetType, @Nullable String reason) {
+ if (reason == null) {
+ return new TableException(
+ "Cannot parse STRING to " + targetType,
+ new NumberFormatException("For input string: \"" + input + "\""));
+ }
+
+ return new TableException(
+ "Cannot parse STRING to " + targetType,
+ new NumberFormatException("For input string: \"" + input + "\". " + reason));
+ }
+
+ public static int toDate(BinaryStringData str) throws TableException {
+ Integer date = DateTimeUtils.dateStringToUnixDate(str.toString());
+ if (date == null) {
+ throw new TableException("Cannot parse STRING to DATE");
}
+
+ return date;
+ }
+
+ public static int toTime(BinaryStringData str) throws TableException {
+ Integer date = DateTimeUtils.timeStringToUnixDate(str.toString());
+ if (date == null) {
+ throw new TableException("Cannot parse STRING to TIME");
+ }
+
+ return date;
+ }
+
+ public static TimestampData toTimestamp(BinaryStringData str) throws TableException {
+ TimestampData timestamp = DateTimeUtils.toTimestampData(str.toString());
+ if (timestamp == null) {
+ throw new TableException("Cannot parse STRING to TIMESTAMP");
+ }
+
+ return timestamp;
+ }
+
+ public static TimestampData toTimestamp(BinaryStringData str, TimeZone timeZone)
+ throws TableException {
+ Long timestamp = DateTimeUtils.toTimestamp(str.toString(), timeZone);
+ if (timestamp == null) {
+ throw new TableException("Cannot parse STRING to TIMESTAMP_LTZ");
Review comment:
Probably it makes sense to specify what string cannot be parsed like it is done for `toBoolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r751278021
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/CastRule.java
##########
@@ -45,6 +45,9 @@
CastExecutor<IN, OUT> create(
Context context, LogicalType inputLogicalType, LogicalType targetLogicalType);
+ /** @return true if the cast operation can fail. */
+ boolean isFallible();
Review comment:
sometimes the JavaDoc should be the source for a name: rename to `canFail` and no JavaDoc is required.
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/StringToNumericPrimitiveCastRule.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.casting;
+
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.LogicalTypeFamily;
+
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_BYTE;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_DOUBLE;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_FLOAT;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_INT;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_LONG;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_SHORT;
+import static org.apache.flink.table.planner.functions.casting.CastRuleUtils.staticCall;
+
+/**
+ * {@link LogicalTypeFamily#CHARACTER_STRING} to {@link LogicalTypeFamily#INTEGER_NUMERIC} and
+ * {@link LogicalTypeFamily#APPROXIMATE_NUMERIC} cast rule.
+ */
+class StringToNumericPrimitiveCastRule
+ extends AbstractExpressionCodeGeneratorCastRule<StringData, Number> {
+
+ static final StringToNumericPrimitiveCastRule INSTANCE = new StringToNumericPrimitiveCastRule();
+
+ private StringToNumericPrimitiveCastRule() {
+ super(
+ CastRulePredicate.builder()
+ .input(LogicalTypeFamily.CHARACTER_STRING)
+ .target(LogicalTypeFamily.INTEGER_NUMERIC)
+ .target(LogicalTypeFamily.APPROXIMATE_NUMERIC)
+ .build());
+ }
+
+ @Override
+ public String generateExpression(
+ CodeGeneratorCastRule.Context context,
+ String inputTerm,
+ LogicalType inputLogicalType,
+ LogicalType targetLogicalType) {
+ switch (targetLogicalType.getTypeRoot()) {
+ case TINYINT:
+ return staticCall(STRING_DATA_TO_BYTE(), inputTerm);
+ case SMALLINT:
+ return staticCall(STRING_DATA_TO_SHORT(), inputTerm);
+ case INTEGER:
+ return staticCall(STRING_DATA_TO_INT(), inputTerm);
+ case BIGINT:
+ return staticCall(STRING_DATA_TO_LONG(), inputTerm);
+ case FLOAT:
+ return staticCall(STRING_DATA_TO_FLOAT(), inputTerm);
+ case DOUBLE:
+ return staticCall(STRING_DATA_TO_DOUBLE(), inputTerm);
+ }
+ throw new IllegalArgumentException("This is a rule bug, contact the developers");
Review comment:
usually we use `This is a bug. Please file an issue.`
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -144,12 +151,16 @@
return substrings.toArray(new BinaryStringData[0]);
}
- /** Decide boolean representation of a string. */
- public static Boolean toBooleanSQL(BinaryStringData str) {
+ /** Parse a {@link StringData} to boolean. */
+ public static boolean toBoolean(BinaryStringData str) throws TableException {
Review comment:
move the changes in `BinaryStringDataUtil` in a separate commit to be visible in the log
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -168,21 +179,35 @@ public static BinaryStringData hash(BinaryStringData str, String algorithm)
}
/**
- * Parses this BinaryStringData to DecimalData.
+ * Parses a {@link BinaryStringData} to {@link DecimalData}.
*
- * @return DecimalData value if the parsing was successful, or null if overflow
- * @throws NumberFormatException if the parsing failed.
+ * @return DecimalData value if the parsing was successful.
+ * @throws TableException if the parsing failed or if overflow happened.
*/
- public static DecimalData toDecimal(BinaryStringData str, int precision, int scale) {
+ public static DecimalData toDecimal(BinaryStringData str, int precision, int scale)
+ throws TableException {
str.ensureMaterialized();
- if (DecimalDataUtils.isByteArrayDecimal(precision)
- || DecimalDataUtils.isByteArrayDecimal(str.getSizeInBytes())) {
- return toBigPrecisionDecimal(str, precision, scale);
+ DecimalData data;
+
+ try {
+ if (DecimalDataUtils.isByteArrayDecimal(precision)
+ || DecimalDataUtils.isByteArrayDecimal(str.getSizeInBytes())) {
+ data = toBigPrecisionDecimal(str, precision, scale);
+ } else {
+ int sizeInBytes = str.getSizeInBytes();
+ data =
+ toDecimalFromBytes(
+ precision, scale, getTmpBytes(str, sizeInBytes), 0, sizeInBytes);
+ }
+ } catch (NumberFormatException e) {
+ throw new TableException("Cannot parse STRING to DECIMAL", e);
Review comment:
very nit: `.` at the end of all exception messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
* 10856191a880a04a242bd69e19a657d7c5b9ef4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
* 746084b9af7389bab70294dce23bd5d192b5acee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750220364
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ byte result = (byte) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "BYTE", "Overflow");
}
- public static Double toDouble(BinaryStringData str) {
+ public static double toDouble(BinaryStringData str) throws TableException {
try {
- return Double.valueOf(str.toString());
+ return Double.parseDouble(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to DOUBLE", e);
}
}
- public static Float toFloat(BinaryStringData str) {
+ public static float toFloat(BinaryStringData str) throws TableException {
try {
- return Float.valueOf(str.toString());
+ return Float.parseFloat(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to FLOAT", e);
Review comment:
Same as https://github.com/apache/flink/pull/17800#discussion_r750220243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750229185
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +549,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, typeName, "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, typeName, "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str, "SHORT");
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str, "SHORT");
Review comment:
I think it should be `BYTE` here like
```suggestion
int intValue = toInt(str, "BYTE");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
* 746084b9af7389bab70294dce23bd5d192b5acee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
* 10856191a880a04a242bd69e19a657d7c5b9ef4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
* 10856191a880a04a242bd69e19a657d7c5b9ef4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750216653
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ byte result = (byte) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "BYTE", "Overflow");
}
- public static Double toDouble(BinaryStringData str) {
+ public static double toDouble(BinaryStringData str) throws TableException {
try {
- return Double.valueOf(str.toString());
+ return Double.parseDouble(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to DOUBLE", e);
Review comment:
Probably it makes sense to specify what string cannot be parsed like it is done for `toBoolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969099477
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e13ad4997b8de7698bd3e525f894d144225d9656 (Mon Nov 15 16:44:57 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
* 746084b9af7389bab70294dce23bd5d192b5acee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750214059
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/StringToNumericPrimitiveCastRule.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.casting;
+
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.LogicalTypeFamily;
+
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_BYTE;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_DOUBLE;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_FLOAT;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_INT;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_LONG;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_SHORT;
+import static org.apache.flink.table.planner.functions.casting.CastRuleUtils.staticCall;
+
+/**
+ * {@link LogicalTypeFamily#CHARACTER_STRING} to {@link LogicalTypeFamily#INTEGER_NUMERIC} and
+ * {@link LogicalTypeFamily#APPROXIMATE_NUMERIC} cast rule.
+ */
+class StringToNumericPrimitiveCastRule
+ extends AbstractExpressionCodeGeneratorCastRule<StringData, Number> {
+
+ static final StringToNumericPrimitiveCastRule INSTANCE = new StringToNumericPrimitiveCastRule();
+
+ private StringToNumericPrimitiveCastRule() {
+ super(
+ CastRulePredicate.builder()
+ .input(LogicalTypeFamily.CHARACTER_STRING)
+ .target(LogicalTypeFamily.INTEGER_NUMERIC)
+ .target(LogicalTypeFamily.APPROXIMATE_NUMERIC)
+ .build());
+ }
+
+ @Override
+ public String generateExpression(
+ CodeGeneratorCastRule.Context context,
+ String inputTerm,
+ LogicalType inputLogicalType,
+ LogicalType targetLogicalType) {
+ switch (targetLogicalType.getTypeRoot()) {
+ case TINYINT:
+ return staticCall(STRING_DATA_TO_BYTE(), inputTerm);
+ case SMALLINT:
+ return staticCall(STRING_DATA_TO_SHORT(), inputTerm);
+ case INTEGER:
+ return staticCall(STRING_DATA_TO_INT(), inputTerm);
+ case BIGINT:
+ return staticCall(STRING_DATA_TO_LONG(), inputTerm);
+ case FLOAT:
+ return staticCall(STRING_DATA_TO_FLOAT(), inputTerm);
+ case DOUBLE:
+ return staticCall(STRING_DATA_TO_DOUBLE(), inputTerm);
+ }
+ throw new IllegalArgumentException("This is a rule bug, contact the developers");
Review comment:
May be it makes sense to pass `getTypeRoot` to exception to simplify debug in future...
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750217237
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ byte result = (byte) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "BYTE", "Overflow");
}
- public static Double toDouble(BinaryStringData str) {
+ public static double toDouble(BinaryStringData str) throws TableException {
try {
- return Double.valueOf(str.toString());
+ return Double.parseDouble(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to DOUBLE", e);
}
}
- public static Float toFloat(BinaryStringData str) {
+ public static float toFloat(BinaryStringData str) throws TableException {
try {
- return Float.valueOf(str.toString());
+ return Float.parseFloat(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to FLOAT", e);
+ }
+ }
+
+ private static TableException numberFormatExceptionFor(
+ StringData input, String targetType, @Nullable String reason) {
+ if (reason == null) {
+ return new TableException(
+ "Cannot parse STRING to " + targetType,
+ new NumberFormatException("For input string: \"" + input + "\""));
+ }
+
+ return new TableException(
+ "Cannot parse STRING to " + targetType,
+ new NumberFormatException("For input string: \"" + input + "\". " + reason));
+ }
+
+ public static int toDate(BinaryStringData str) throws TableException {
+ Integer date = DateTimeUtils.dateStringToUnixDate(str.toString());
+ if (date == null) {
+ throw new TableException("Cannot parse STRING to DATE");
Review comment:
Probably it makes sense to specify what string cannot be parsed like it is done for `toBoolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26768",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
* 10856191a880a04a242bd69e19a657d7c5b9ef4b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26768)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
* 746084b9af7389bab70294dce23bd5d192b5acee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17800:
URL: https://github.com/apache/flink/pull/17800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750217355
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ byte result = (byte) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "BYTE", "Overflow");
}
- public static Double toDouble(BinaryStringData str) {
+ public static double toDouble(BinaryStringData str) throws TableException {
try {
- return Double.valueOf(str.toString());
+ return Double.parseDouble(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to DOUBLE", e);
}
}
- public static Float toFloat(BinaryStringData str) {
+ public static float toFloat(BinaryStringData str) throws TableException {
try {
- return Float.valueOf(str.toString());
+ return Float.parseFloat(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to FLOAT", e);
+ }
+ }
+
+ private static TableException numberFormatExceptionFor(
+ StringData input, String targetType, @Nullable String reason) {
+ if (reason == null) {
+ return new TableException(
+ "Cannot parse STRING to " + targetType,
+ new NumberFormatException("For input string: \"" + input + "\""));
+ }
+
+ return new TableException(
+ "Cannot parse STRING to " + targetType,
+ new NumberFormatException("For input string: \"" + input + "\". " + reason));
+ }
+
+ public static int toDate(BinaryStringData str) throws TableException {
+ Integer date = DateTimeUtils.dateStringToUnixDate(str.toString());
+ if (date == null) {
+ throw new TableException("Cannot parse STRING to DATE");
}
+
+ return date;
+ }
+
+ public static int toTime(BinaryStringData str) throws TableException {
+ Integer date = DateTimeUtils.timeStringToUnixDate(str.toString());
+ if (date == null) {
+ throw new TableException("Cannot parse STRING to TIME");
Review comment:
Probably it makes sense to specify what string cannot be parsed like it is done for `toBoolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750220243
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ byte result = (byte) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "BYTE", "Overflow");
}
- public static Double toDouble(BinaryStringData str) {
+ public static double toDouble(BinaryStringData str) throws TableException {
try {
- return Double.valueOf(str.toString());
+ return Double.parseDouble(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to DOUBLE", e);
Review comment:
The `NumberFormatException` should already include the bad string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r751988625
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -144,12 +151,16 @@
return substrings.toArray(new BinaryStringData[0]);
}
- /** Decide boolean representation of a string. */
- public static Boolean toBooleanSQL(BinaryStringData str) {
+ /** Parse a {@link StringData} to boolean. */
+ public static boolean toBoolean(BinaryStringData str) throws TableException {
Review comment:
I can't easily extract the changes of `BinaryStringDataUtil` without creating commits that won't build, I renamed the commit where the big changes happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26768",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b854a72738520eced2579220fd9770412f87f354 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
* 10856191a880a04a242bd69e19a657d7c5b9ef4b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26768)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-970229004
@snuyanzin Updated with feedback. The issue with date/time methods in particular is that the parsing methods from `DateTimeUtils` should fail, instead or returning boxed null values, and they should fail with proper exceptions explaining why. I want to avoid to tackle this particular aspect of the issue in this PR, since these methods are used in other parts of the codegen. I hope to fix once for all the behavior of these methods in the context of https://issues.apache.org/jira/browse/FLINK-24507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606)
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606)
* 05798894d1ceb42e6616eee231ed7462e6ffc94e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 746084b9af7389bab70294dce23bd5d192b5acee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 746084b9af7389bab70294dce23bd5d192b5acee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697)
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
* 746084b9af7389bab70294dce23bd5d192b5acee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
* 10856191a880a04a242bd69e19a657d7c5b9ef4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26768",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10856191a880a04a242bd69e19a657d7c5b9ef4b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26768)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-972646946
I rebased the PR so it can be merged like it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750156313
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
Review comment:
It seems that in case of value out of int range it will complain with `Table Cannot parse STRING to INT` instead of `Table Cannot parse STRING to SHORT`
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
Review comment:
It seems that in case of value out of int range it will complain with `Table Cannot parse STRING to INT` instead of `Table Cannot parse STRING to BYTE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750218988
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/StringToNumericPrimitiveCastRule.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.casting;
+
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.LogicalTypeFamily;
+
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_BYTE;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_DOUBLE;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_FLOAT;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_INT;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_LONG;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_SHORT;
+import static org.apache.flink.table.planner.functions.casting.CastRuleUtils.staticCall;
+
+/**
+ * {@link LogicalTypeFamily#CHARACTER_STRING} to {@link LogicalTypeFamily#INTEGER_NUMERIC} and
+ * {@link LogicalTypeFamily#APPROXIMATE_NUMERIC} cast rule.
+ */
+class StringToNumericPrimitiveCastRule
+ extends AbstractExpressionCodeGeneratorCastRule<StringData, Number> {
+
+ static final StringToNumericPrimitiveCastRule INSTANCE = new StringToNumericPrimitiveCastRule();
+
+ private StringToNumericPrimitiveCastRule() {
+ super(
+ CastRulePredicate.builder()
+ .input(LogicalTypeFamily.CHARACTER_STRING)
+ .target(LogicalTypeFamily.INTEGER_NUMERIC)
+ .target(LogicalTypeFamily.APPROXIMATE_NUMERIC)
+ .build());
+ }
+
+ @Override
+ public String generateExpression(
+ CodeGeneratorCastRule.Context context,
+ String inputTerm,
+ LogicalType inputLogicalType,
+ LogicalType targetLogicalType) {
+ switch (targetLogicalType.getTypeRoot()) {
+ case TINYINT:
+ return staticCall(STRING_DATA_TO_BYTE(), inputTerm);
+ case SMALLINT:
+ return staticCall(STRING_DATA_TO_SHORT(), inputTerm);
+ case INTEGER:
+ return staticCall(STRING_DATA_TO_INT(), inputTerm);
+ case BIGINT:
+ return staticCall(STRING_DATA_TO_LONG(), inputTerm);
+ case FLOAT:
+ return staticCall(STRING_DATA_TO_FLOAT(), inputTerm);
+ case DOUBLE:
+ return staticCall(STRING_DATA_TO_DOUBLE(), inputTerm);
+ }
+ throw new IllegalArgumentException("This is a rule bug, contact the developers");
Review comment:
I don't know, this branch should never be took anyway given that if the type is not one of those in the branch, the rule will never be matched... I can add the type root, but i don't think it helps anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750215736
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -168,21 +179,35 @@ public static BinaryStringData hash(BinaryStringData str, String algorithm)
}
/**
- * Parses this BinaryStringData to DecimalData.
+ * Parses a {@link BinaryStringData} to {@link DecimalData}.
*
- * @return DecimalData value if the parsing was successful, or null if overflow
- * @throws NumberFormatException if the parsing failed.
+ * @return DecimalData value if the parsing was successful.
+ * @throws TableException if the parsing failed or if overflow happened.
*/
- public static DecimalData toDecimal(BinaryStringData str, int precision, int scale) {
+ public static DecimalData toDecimal(BinaryStringData str, int precision, int scale)
+ throws TableException {
str.ensureMaterialized();
- if (DecimalDataUtils.isByteArrayDecimal(precision)
- || DecimalDataUtils.isByteArrayDecimal(str.getSizeInBytes())) {
- return toBigPrecisionDecimal(str, precision, scale);
+ DecimalData data;
+
+ try {
+ if (DecimalDataUtils.isByteArrayDecimal(precision)
+ || DecimalDataUtils.isByteArrayDecimal(str.getSizeInBytes())) {
+ data = toBigPrecisionDecimal(str, precision, scale);
+ } else {
+ int sizeInBytes = str.getSizeInBytes();
+ data =
+ toDecimalFromBytes(
+ precision, scale, getTmpBytes(str, sizeInBytes), 0, sizeInBytes);
+ }
+ } catch (NumberFormatException e) {
+ throw new TableException("Cannot parse string to decimal", e);
}
- int sizeInBytes = str.getSizeInBytes();
- return toDecimalFromBytes(precision, scale, getTmpBytes(str, sizeInBytes), 0, sizeInBytes);
+ if (data == null) {
+ throw new TableException("Cannot parse string to decimal");
Review comment:
Probably it makes sense to specify what string cannot be parsed like it is done for `toBoolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
* 278ea715885080ec9ba3bce25c0f5ffabf31be3f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603)
* 7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "60045ccee32ba8239baf8c0213e4c91a5c87ff41",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "60045ccee32ba8239baf8c0213e4c91a5c87ff41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* 60045ccee32ba8239baf8c0213e4c91a5c87ff41 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750216841
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -525,56 +545,102 @@ public static Integer toInt(BinaryStringData str) {
while (i < sizeInBytes) {
byte currentByte = tmpBytes[i];
if (currentByte < '0' || currentByte > '9') {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Invalid character found");
}
i++;
}
if (!negative) {
result = -result;
if (result < 0) {
- return null;
+ throw numberFormatExceptionFor(str, "INT", "Overflow");
}
}
return result;
}
- public static Short toShort(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- short result = intValue.shortValue();
- if (result == intValue) {
- return result;
- }
+ public static short toShort(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ short result = (short) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "SHORT", "Overflow");
}
- public static Byte toByte(BinaryStringData str) {
- Integer intValue = toInt(str);
- if (intValue != null) {
- byte result = intValue.byteValue();
- if (result == intValue) {
- return result;
- }
+ public static byte toByte(BinaryStringData str) throws TableException {
+ int intValue = toInt(str);
+ byte result = (byte) intValue;
+ if (result == intValue) {
+ return result;
}
- return null;
+ throw numberFormatExceptionFor(str, "BYTE", "Overflow");
}
- public static Double toDouble(BinaryStringData str) {
+ public static double toDouble(BinaryStringData str) throws TableException {
try {
- return Double.valueOf(str.toString());
+ return Double.parseDouble(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to DOUBLE", e);
}
}
- public static Float toFloat(BinaryStringData str) {
+ public static float toFloat(BinaryStringData str) throws TableException {
try {
- return Float.valueOf(str.toString());
+ return Float.parseFloat(str.toString());
} catch (NumberFormatException e) {
- return null;
+ throw new TableException("Cannot parse STRING to FLOAT", e);
Review comment:
Probably it makes sense to specify what string cannot be parsed like it is done for `toBoolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750215594
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java
##########
@@ -168,21 +179,35 @@ public static BinaryStringData hash(BinaryStringData str, String algorithm)
}
/**
- * Parses this BinaryStringData to DecimalData.
+ * Parses a {@link BinaryStringData} to {@link DecimalData}.
*
- * @return DecimalData value if the parsing was successful, or null if overflow
- * @throws NumberFormatException if the parsing failed.
+ * @return DecimalData value if the parsing was successful.
+ * @throws TableException if the parsing failed or if overflow happened.
*/
- public static DecimalData toDecimal(BinaryStringData str, int precision, int scale) {
+ public static DecimalData toDecimal(BinaryStringData str, int precision, int scale)
+ throws TableException {
str.ensureMaterialized();
- if (DecimalDataUtils.isByteArrayDecimal(precision)
- || DecimalDataUtils.isByteArrayDecimal(str.getSizeInBytes())) {
- return toBigPrecisionDecimal(str, precision, scale);
+ DecimalData data;
+
+ try {
+ if (DecimalDataUtils.isByteArrayDecimal(precision)
+ || DecimalDataUtils.isByteArrayDecimal(str.getSizeInBytes())) {
+ data = toBigPrecisionDecimal(str, precision, scale);
+ } else {
+ int sizeInBytes = str.getSizeInBytes();
+ data =
+ toDecimalFromBytes(
+ precision, scale, getTmpBytes(str, sizeInBytes), 0, sizeInBytes);
+ }
+ } catch (NumberFormatException e) {
+ throw new TableException("Cannot parse string to decimal", e);
Review comment:
Probably it makes sense to specify what string cannot be parsed like it is done for `toBoolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17800:
URL: https://github.com/apache/flink/pull/17800#discussion_r750218988
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/StringToNumericPrimitiveCastRule.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.casting;
+
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.LogicalTypeFamily;
+
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_BYTE;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_DOUBLE;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_FLOAT;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_INT;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_LONG;
+import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.STRING_DATA_TO_SHORT;
+import static org.apache.flink.table.planner.functions.casting.CastRuleUtils.staticCall;
+
+/**
+ * {@link LogicalTypeFamily#CHARACTER_STRING} to {@link LogicalTypeFamily#INTEGER_NUMERIC} and
+ * {@link LogicalTypeFamily#APPROXIMATE_NUMERIC} cast rule.
+ */
+class StringToNumericPrimitiveCastRule
+ extends AbstractExpressionCodeGeneratorCastRule<StringData, Number> {
+
+ static final StringToNumericPrimitiveCastRule INSTANCE = new StringToNumericPrimitiveCastRule();
+
+ private StringToNumericPrimitiveCastRule() {
+ super(
+ CastRulePredicate.builder()
+ .input(LogicalTypeFamily.CHARACTER_STRING)
+ .target(LogicalTypeFamily.INTEGER_NUMERIC)
+ .target(LogicalTypeFamily.APPROXIMATE_NUMERIC)
+ .build());
+ }
+
+ @Override
+ public String generateExpression(
+ CodeGeneratorCastRule.Context context,
+ String inputTerm,
+ LogicalType inputLogicalType,
+ LogicalType targetLogicalType) {
+ switch (targetLogicalType.getTypeRoot()) {
+ case TINYINT:
+ return staticCall(STRING_DATA_TO_BYTE(), inputTerm);
+ case SMALLINT:
+ return staticCall(STRING_DATA_TO_SHORT(), inputTerm);
+ case INTEGER:
+ return staticCall(STRING_DATA_TO_INT(), inputTerm);
+ case BIGINT:
+ return staticCall(STRING_DATA_TO_LONG(), inputTerm);
+ case FLOAT:
+ return staticCall(STRING_DATA_TO_FLOAT(), inputTerm);
+ case DOUBLE:
+ return staticCall(STRING_DATA_TO_DOUBLE(), inputTerm);
+ }
+ throw new IllegalArgumentException("This is a rule bug, contact the developers");
Review comment:
I don't know, this branch should never be took anyway given that if the type is not one of those in the various case branches, the rule will never be matched... I can add the type root, but i don't think it helps anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-970237415
thank you very much.
No more comments from my side.
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e13ad4997b8de7698bd3e525f894d144225d9656 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558)
* b5e97d01c729ba9b86cf6777e6fa14bd5c672857 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05798894d1ceb42e6616eee231ed7462e6ffc94e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688)
* 746084b9af7389bab70294dce23bd5d192b5acee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 746084b9af7389bab70294dce23bd5d192b5acee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697)
* dae8138b6cd751e7a912e6598cb5bbde251c185d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
* 10856191a880a04a242bd69e19a657d7c5b9ef4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
}, {
"hash" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10856191a880a04a242bd69e19a657d7c5b9ef4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
* 10856191a880a04a242bd69e19a657d7c5b9ef4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17800: [FLINK-24781] Add to string casting rules
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17800:
URL: https://github.com/apache/flink/pull/17800#issuecomment-969101585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26558",
"triggerID" : "e13ad4997b8de7698bd3e525f894d144225d9656",
"triggerType" : "PUSH"
}, {
"hash" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26594",
"triggerID" : "b5e97d01c729ba9b86cf6777e6fa14bd5c672857",
"triggerType" : "PUSH"
}, {
"hash" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26603",
"triggerID" : "278ea715885080ec9ba3bce25c0f5ffabf31be3f",
"triggerType" : "PUSH"
}, {
"hash" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26606",
"triggerID" : "7fe5ac1f749323c56e1afd98a8b8ba8eb633ea60",
"triggerType" : "PUSH"
}, {
"hash" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26688",
"triggerID" : "05798894d1ceb42e6616eee231ed7462e6ffc94e",
"triggerType" : "PUSH"
}, {
"hash" : "746084b9af7389bab70294dce23bd5d192b5acee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26697",
"triggerID" : "746084b9af7389bab70294dce23bd5d192b5acee",
"triggerType" : "PUSH"
}, {
"hash" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745",
"triggerID" : "dae8138b6cd751e7a912e6598cb5bbde251c185d",
"triggerType" : "PUSH"
}, {
"hash" : "b854a72738520eced2579220fd9770412f87f354",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765",
"triggerID" : "b854a72738520eced2579220fd9770412f87f354",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dae8138b6cd751e7a912e6598cb5bbde251c185d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26745)
* b854a72738520eced2579220fd9770412f87f354 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26765)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org