You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Thijs Vonk (JIRA)" <ji...@apache.org> on 2012/09/18 16:07:07 UTC
[jira] [Created] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Thijs Vonk created WICKET-4769:
----------------------------------
Summary: Clicking on Label of Radio doesn't update component with Ajax update
Key: WICKET-4769
URL: https://issues.apache.org/jira/browse/WICKET-4769
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.0.0
Reporter: Thijs Vonk
We just upgraded a application from wicket 1.4 to wicket 6.
We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-4769:
-------------------------------------
Fix Version/s: (was: 6.1.0)
6.2.0
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467700#comment-13467700 ]
Thijs Vonk commented on WICKET-4769:
------------------------------------
When I comment out target.add(group); it still fires the ajax call twice.
Only difference is that now the selection stay's
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467992#comment-13467992 ]
Martin Grigorov commented on WICKET-4769:
-----------------------------------------
I think I solved it.
Please try the latest code in master branch.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thijs Vonk updated WICKET-4769:
-------------------------------
Attachment: test14.zip
test.zip
test runs on port 8080
test14 runs on port 8081
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Attachments: test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-4769:
-------------------------------------
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467968#comment-13467968 ]
Thijs Vonk commented on WICKET-4769:
------------------------------------
Ah yes. But as sone as you pull the click event to an wrapping div: http://jsfiddle.net/LmMuy/ (which is basically the same as my earlier example) it gives the same behavior of the double event.
(May be I'm now stating the obvious, not sure I understood your comment completely)
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467645#comment-13467645 ]
Thijs Vonk commented on WICKET-4769:
------------------------------------
I build wicket from source, but the example provided in test.zip (and so also my application) still don't work. Can this be reopened?
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Aaron J. Garcia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460030#comment-13460030 ]
Aaron J. Garcia commented on WICKET-4769:
-----------------------------------------
I'm also having this issue, but I went from 1.5.8 -> 6.0.0. I have a Quick Start too, which I will attach. It seems that this only happens when the RadioChoice form component is inside of a form. When I had a RadioChoice component outside of the form, the issue wasn't occurring.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Attachments: test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Aaron J. Garcia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron J. Garcia updated WICKET-4769:
------------------------------------
Attachment: radio-choice-bug-6.0.0.tar
Another quick start that illustrates the issue.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467969#comment-13467969 ]
Martin Grigorov commented on WICKET-4769:
-----------------------------------------
I just committed a change [1] which I'll have to revert :-/
It works only if the choice component is repainted with the Ajax response.
1. https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=881d03ec84ead3386d37faf0eecf50d05fe30ac9
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WICKET-4769) Clicking on Label of Radio
doesn't update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467917#comment-13467917 ]
Thijs Vonk edited comment on WICKET-4769 at 10/3/12 5:17 AM:
-------------------------------------------------------------
The repainting of the dom doesn't trigger the second event.
When you click on the label 2 click events are fired. If you click on the radio button there is only one event.
See the attached html file demonstrating the issue.
This causes the ajax request to happen twice, with all kinds of weird side effects.
some extra info: http://bugs.jquery.com/ticket/10673
was (Author: thyzz):
The repainting of the dom doesn't trigger the second event.
When you click on the label 2 click events are fired. If you click on the radio button there is only one event.
See the attached html file demonstrating the issue.
This causes the ajax request to happen twice, with all kinds of weird side effects.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Aaron J. Garcia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460035#comment-13460035 ]
Aaron J. Garcia commented on WICKET-4769:
-----------------------------------------
Some more details (sorry for the multiple comments):
Java Version: 1.7.0_04
Tomcat Version: 7.0.27
Firefox Version: 15.0
Operating System: Open Suse 11.4
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4769.
-------------------------------------
Resolution: Fixed
Assignee: Martin Grigorov
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4769:
------------------------------------
Fix Version/s: 6.1.0
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Fix For: 6.1.0
>
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460284#comment-13460284 ]
Thijs Vonk commented on WICKET-4769:
------------------------------------
In my example the radio is inside a radiogroup, not in a form.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467993#comment-13467993 ]
Sven Meier commented on WICKET-4769:
------------------------------------
I have a solution for WICKET-4797 ready that would solve this issue too. May I interrupt your check-ins for a moment?
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467680#comment-13467680 ]
Martin Grigorov commented on WICKET-4769:
-----------------------------------------
When I debugged it I used radio-choice-bug-6.0.0.tar...
Testing with test.zip I see that it fires the Ajax event twice - the second time it comes after repainting the group.
By just commenting out the line:
target.add(group);
in TestPage it starts working.
I have no idea why it fires 'click' event after the DOM replacements.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thijs Vonk updated WICKET-4769:
-------------------------------
Attachment: radio-label.html
The repainting of the dom doesn't trigger the second event.
When you click on the label 2 click events are fired. If you click on the radio button there is only one event.
See the attached html file demonstrating the issue.
This causes the ajax request to happen twice, with all kinds of weird side effects.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467951#comment-13467951 ]
Martin Grigorov commented on WICKET-4769:
-----------------------------------------
It is not the same. In your code the <label> doesn't wrap the <input>.
http://jsfiddle.net/HKGsT/14/ works as expected.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4769.
-------------------------------------
Resolution: Fixed
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468048#comment-13468048 ]
Sven Meier commented on WICKET-4769:
------------------------------------
I've checked a solution for WICKET-4797 which addresses this issue too. Now the input name is used for Ajax precondition and identification of checked inputs, which hopefully is much simpler to understand and maintain.
I took the opportunity to impoved the Javascript similar Carl-Eric's AbstractCheckSelector.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468389#comment-13468389 ]
Thijs Vonk commented on WICKET-4769:
------------------------------------
It works! Thanks Martin and Sven
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467693#comment-13467693 ]
Thijs Vonk commented on WICKET-4769:
------------------------------------
I wish I could comment out that line in my reallife application. There it's part of a larger repaint action.
I'll start digging, to see if I can find out why it gets repainted a second time.
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4769) Clicking on Label of Radio doesn't
update component with Ajax update
Posted by "Thijs Vonk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468002#comment-13468002 ]
Thijs Vonk commented on WICKET-4769:
------------------------------------
The test case (as in test.zip) works!!
Tomorrow, when I'm actually working, i'll try the big app where I found the issue. Thanks so far
> Clicking on Label of Radio doesn't update component with Ajax update
> --------------------------------------------------------------------
>
> Key: WICKET-4769
> URL: https://issues.apache.org/jira/browse/WICKET-4769
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Thijs Vonk
> Assignee: Martin Grigorov
> Fix For: 6.2.0
>
> Attachments: radio-choice-bug-6.0.0.tar, radio-label.html, test14.zip, test.zip
>
>
> We just upgraded a application from wicket 1.4 to wicket 6.
> We discovered that when clicking on the label of a radio button that has a AjaxFormChoiceComponentUpdatingBehavior attached the radio is not selected.
> I'll attach 2 testcases (one for wicket 1.4 and one for wicket 6)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira