You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ta...@apache.org on 2021/03/12 06:43:15 UTC
[hadoop] branch trunk updated: HDFS-15848. Snapshot Operations: Add
debug logs at the entry point. Contributed by Bhavik Patel.
This is an automated email from the ASF dual-hosted git repository.
tasanuma pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new ecd3335 HDFS-15848. Snapshot Operations: Add debug logs at the entry point. Contributed by Bhavik Patel.
ecd3335 is described below
commit ecd3335187f3beb05ba82cea3d7d8467c09f6e61
Author: Takanobu Asanuma <ta...@apache.org>
AuthorDate: Fri Mar 12 15:42:15 2021 +0900
HDFS-15848. Snapshot Operations: Add debug logs at the entry point. Contributed by Bhavik Patel.
---
.../apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java | 11 ++++++++++-
.../apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java | 7 +++++++
.../hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java | 3 ++-
3 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
index d45c0c3..8925f00 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
@@ -36,6 +36,8 @@ import org.apache.hadoop.hdfs.server.namenode.snapshot.SnapshotManager;
import org.apache.hadoop.hdfs.util.ReadOnlyList;
import org.apache.hadoop.util.ChunkedArrayList;
import org.apache.hadoop.util.Time;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import java.io.IOException;
import java.util.ArrayList;
@@ -43,6 +45,9 @@ import java.util.Collection;
import java.util.List;
class FSDirSnapshotOp {
+ public static final Logger LOG =
+ LoggerFactory.getLogger(FSDirSnapshotOp.class);
+
/** Verify if the snapshot name is legal. */
static void verifySnapshotName(FSDirectory fsd, String snapshotName,
String path)
@@ -118,7 +123,7 @@ class FSDirSnapshotOp {
}
fsd.getEditLog().logCreateSnapshot(snapshotRoot, snapshotName,
logRetryCache, now);
-
+ LOG.info("Created Snapshot for SnapshotRoot {}", snapshotRoot);
return snapshotPath;
}
@@ -141,6 +146,8 @@ class FSDirSnapshotOp {
}
fsd.getEditLog().logRenameSnapshot(path, snapshotOldName,
snapshotNewName, logRetryCache, now);
+ LOG.info("Snapshot renamed from {} to {} for SnapshotRoot {}",
+ snapshotOldName, snapshotNewName, path);
}
static SnapshottableDirectoryStatus[] getSnapshottableDirListing(
@@ -271,6 +278,8 @@ class FSDirSnapshotOp {
final INode.BlocksMapUpdateInfo collectedBlocks = deleteSnapshot(
fsd, snapshotManager, iip, snapshotName, now, snapshotRoot,
logRetryCache);
+ LOG.info("Snapshot {} deleted for SnapshotRoot {}",
+ snapshotName, snapshotName);
return collectedBlocks;
}
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
index 70b12b3..cfb0d44 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
@@ -1899,6 +1899,8 @@ public class NameNodeRpcServer implements NamenodeProtocols {
public String createSnapshot(String snapshotRoot, String snapshotName)
throws IOException {
checkNNStartup();
+ LOG.debug("*DIR* NameNode.createSnapshot: Path {} and SnapshotName {}",
+ snapshotRoot, snapshotName);
if (!checkPathLength(snapshotRoot)) {
throw new IOException("createSnapshot: Pathname too long. Limit "
+ MAX_PATH_LENGTH + " characters, " + MAX_PATH_DEPTH + " levels.");
@@ -1925,6 +1927,8 @@ public class NameNodeRpcServer implements NamenodeProtocols {
public void deleteSnapshot(String snapshotRoot, String snapshotName)
throws IOException {
checkNNStartup();
+ LOG.debug("*DIR* NameNode.deleteSnapshot: Path {} and SnapshotName {}",
+ snapshotRoot, snapshotName);
if (snapshotName == null || snapshotName.isEmpty()) {
throw new IOException("The snapshot name is null or empty.");
}
@@ -1964,6 +1968,9 @@ public class NameNodeRpcServer implements NamenodeProtocols {
public void renameSnapshot(String snapshotRoot, String snapshotOldName,
String snapshotNewName) throws IOException {
checkNNStartup();
+ LOG.debug("*DIR* NameNode.renameSnapshot: Snapshot Path {}, " +
+ "snapshotOldName {}, snapshotNewName {}", snapshotRoot,
+ snapshotOldName, snapshotNewName);
if (snapshotNewName == null || snapshotNewName.isEmpty()) {
throw new IOException("The new snapshot name is null or empty.");
}
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java
index 16e654c..68bf998 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java
@@ -457,7 +457,8 @@ public class SnapshotManager implements SnapshotStatsMXBean {
// requests.
throw new SnapshotException(
"Failed to create the snapshot. The FileSystem has run out of " +
- "snapshot IDs and ID rollover is not supported.");
+ "snapshot IDs and ID rollover is not supported " +
+ "and the max snapshot limit is: " + maxSnapshotLimit);
}
int n = numSnapshots.get();
checkFileSystemSnapshotLimit(n);
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org