[GitHub] [tvm] farshidsp commented on a diff in pull request #14379: [TIR] not estimating the flops when there is a default estimated flops as attr

["farshidsp (via GitHub)" <gi...@apache.org>]

farshidsp commented on code in PR #14379:
URL: https://github.com/apache/tvm/pull/14379#discussion_r1146847384


##########
tests/python/unittest/test_tir_analysis_estimate_tir_flops.py:
##########
@@ -77,5 +77,39 @@ def test_flops_with_if():
     assert flops == 16
 
 
+@T.prim_func
+def flops_with_forloop_as_expression(A: T.Buffer(1)):
+    for i in T.serial(0, 16):
+        for k in T.serial(0, i):
+            A[0] = A[0] + 1
+
+
+@T.prim_func
+def flops_override(a: T.Buffer(16, "float32"), b: T.Buffer(16, "float32")):

Review Comment:
   Sounds good Eric. Thanks for the suggestion. Fixed in the next commit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org