You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/01 01:30:35 UTC

[GitHub] [spark] beliefer opened a new pull request #36032: [SPARK-37960][SQL][FOLLOWUP] Make the testing CASE WHEN query more reasonable

beliefer opened a new pull request #36032:
URL: https://github.com/apache/spark/pull/36032


   ### What changes were proposed in this pull request?
   Some testing CASE WHEN queries are not carefully written and do not make sense. In the future, the optimizer may get smarter and get rid of the CASE WHEN completely, and then we loose test coverage.
   
   This PR updates some CASE WHEN queries to make them more reasonable.
   
   
   ### Why are the changes needed?
   future-proof test coverage.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   
   
   ### How was this patch tested?
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #36032: [SPARK-37960][SQL][FOLLOWUP] Make the testing CASE WHEN query more reasonable

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #36032:
URL: https://github.com/apache/spark/pull/36032#issuecomment-1085443167


   thanks, merging to master/3.3!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #36032: [SPARK-37960][SQL][FOLLOWUP] Make the testing CASE WHEN query more reasonable

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #36032:
URL: https://github.com/apache/spark/pull/36032#issuecomment-1085446593


   @cloud-fan Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #36032: [SPARK-37960][SQL][FOLLOWUP] Make the testing CASE WHEN query more reasonable

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #36032:
URL: https://github.com/apache/spark/pull/36032


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #36032: [SPARK-37960][SQL][FOLLOWUP] Make the testing CASE WHEN query more reasonable

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #36032:
URL: https://github.com/apache/spark/pull/36032#issuecomment-1085300119


   This PR used to replace https://github.com/apache/spark/pull/35818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #36032: [SPARK-37960][SQL][FOLLOWUP] Make the testing CASE WHEN query more reasonable

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #36032:
URL: https://github.com/apache/spark/pull/36032#issuecomment-1085440296


   ping @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org