You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/21 10:54:37 UTC

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7526: Kafka extra producer configuration enhancement

kezhenxu94 commented on a change in pull request #7526:
URL: https://github.com/apache/skywalking/pull/7526#discussion_r693339573



##########
File path: apm-sniffer/optional-reporter-plugins/kafka-reporter-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
##########
@@ -102,6 +104,10 @@ public void run() {
         Properties properties = new Properties();
         properties.setProperty(
             ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, KafkaReporterPluginConfig.Plugin.Kafka.BOOTSTRAP_SERVERS);
+
+        Map<String, String> producerConfig = (Map<String, String>) new Gson()

Review comment:
       Extract `new Gson()` as a field




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org