[GitHub] [helix] dasahcc commented on a change in pull request #1715: Change MessageQueueMonitor from static to dynamic metric

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #1715:
URL: https://github.com/apache/helix/pull/1715#discussion_r621481848



##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitor.java
##########
@@ -70,9 +72,9 @@ public void init() {
    * Remove this bean from the server
    */
   public void reset() {
-    _messageQueueBacklog = 0;
+    _messageQueueBacklog.updateValue(0L);
     try {
-      unregister(getObjectName(getBeanName()));
+      unregister();
     } catch (Exception e) {
       LOG.error("Fail to register MessageQueueMonitor", e);

Review comment:
       NIT: Am I missed something in another PR? I did not find the unregister() function.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org