[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3668: [CARBONDATA-3741] Fix ParseException from hive during ALTER SET TBLPROERTIES if database name starts with Underscore

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #3668: [CARBONDATA-3741] Fix ParseException from hive during ALTER SET TBLPROERTIES if database name starts with Underscore
URL: https://github.com/apache/carbondata/pull/3668#discussion_r392973432
 
 

 ##########
 File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/InsertIntoCarbonTableSpark2TestCase.scala
 ##########
 @@ -31,7 +31,21 @@ class InsertIntoCarbonTableSpark2TestCase extends QueryTest with BeforeAndAfterA
     checkAnswer(sql("select * from OneRowTable"), Seq(Row("0.1", "a.b", 1, 1.2)))
   }
 
+  test("test insert into with database name having underscore") {
+    sql("drop table if exists OneRowTable")
+    sql("create table OneRowTable(col1 string, col2 string, col3 int, col4 double) STORED AS carbondata")
+    sql("insert into OneRowTable select '0.1', 'a.b', 1, 1.2")
+    checkAnswer(sql("select * from OneRowTable"), Seq(Row("0.1", "a.b", 1, 1.2)))
+    sql("drop database if exists _default cascade")
+    sql("create database _default")
+    sql("create table _default.OneRowTable(col1 string, col2 string, col3 int, col4 double) STORED AS carbondata")
 
 Review comment:
   keep table name also starting from underscore in the testcase

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services