You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/10 09:32:33 UTC
[GitHub] [hudi] hk-lrzy opened a new pull request #3637: [HUDI-2301]support async compaction
hk-lrzy opened a new pull request #3637:
URL: https://github.com/apache/hudi/pull/3637
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
https://issues.apache.org/jira/browse/HUDI-2302
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 closed pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
garyli1019 closed pull request #3637:
URL: https://github.com/apache/hudi/pull/3637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3637: [HUDI-2301]support async compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-916770374
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139",
"triggerID" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#discussion_r718091146
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -430,14 +430,14 @@ private FlinkOptions() {
public static final ConfigOption<Boolean> COMPACTION_SCHEDULE_ENABLED = ConfigOptions
.key("compaction.schedule.enabled")
.booleanType()
- .defaultValue(true) // default true for MOR write
- .withDescription("Schedule the compaction plan, enabled by default for MOR");
+ .defaultValue(false) // default false for MOR write
Review comment:
Fine with the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-1019659570
@hk-lrzy : Can you please follow up on the PR. If async compaction scheduling feature is already landed, feel free to close this one. Trying to see if we can get this in for 0.11.0. So, would appreciate if you can follow up.
I will let Danny and Gary follow up here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-916770374
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139",
"triggerID" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3637: [HUDI-2301]support async compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-916770374
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-961588354
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139",
"triggerID" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on a change in pull request #3637: [HUDI-2301]support async compaction
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#discussion_r706047942
##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/compact/HoodieFlinkCompactor.java
##########
@@ -18,9 +18,16 @@
package org.apache.hudi.sink.compact;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
Review comment:
the import order is wrong here. The checkstyle should fail. please follow hudi -> 3rd party -> java/scala -> static order
##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketAssignFunction.java
##########
@@ -52,7 +52,7 @@
import java.util.Objects;
/**
- * The function to build the write profile incrementally for records within a checkpoint,
+ * The function to build the write phudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.javarofile incrementally for records within a checkpoint,
Review comment:
accident?
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/CompactionUtil.java
##########
@@ -18,6 +18,10 @@
package org.apache.hudi.util;
+import org.apache.flink.configuration.Configuration;
Review comment:
ditto
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -430,14 +430,14 @@ private FlinkOptions() {
public static final ConfigOption<Boolean> COMPACTION_SCHEDULE_ENABLED = ConfigOptions
.key("compaction.schedule.enabled")
.booleanType()
- .defaultValue(true) // default true for MOR write
- .withDescription("Schedule the compaction plan, enabled by default for MOR");
+ .defaultValue(false) // default false for MOR write
Review comment:
@danny0405 WDYT of changing the default value? We could move all the compaction and cleaning stuff to the batch job as the recommended way.
##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/compact/FlinkCompactionConfig.java
##########
@@ -93,7 +93,7 @@
+ "There is a risk of losing data when scheduling compaction outside the writer job.\n"
Review comment:
There is no risk anymore. We could change the description now. Async compaction scheduling is actually recommended.
##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/compact/HoodieFlinkCompactor.java
##########
@@ -29,15 +36,11 @@
import org.apache.hudi.table.HoodieFlinkTable;
import org.apache.hudi.util.CompactionUtil;
import org.apache.hudi.util.StreamerUtil;
-
-import com.beust.jcommander.JCommander;
-import org.apache.flink.api.common.typeinfo.TypeInformation;
-import org.apache.flink.configuration.Configuration;
-import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
-import org.apache.flink.streaming.api.operators.ProcessOperator;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.util.concurrent.TimeUnit;
Review comment:
ditto
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/CompactionUtil.java
##########
@@ -50,18 +50,15 @@
* Gets compaction Instant time.
*/
public static String getCompactionInstantTime(HoodieTableMetaClient metaClient) {
- Option<HoodieInstant> firstPendingInstant = metaClient.getCommitsTimeline()
+ Option<HoodieInstant> firstPendingInstant = metaClient.getActiveTimeline()
.filterPendingExcludingCompaction().firstInstant();
- Option<HoodieInstant> lastCompleteInstant = metaClient.getActiveTimeline().getWriteTimeline()
- .filterCompletedAndCompactionInstants().lastInstant();
- if (firstPendingInstant.isPresent() && lastCompleteInstant.isPresent()) {
+ if (firstPendingInstant.isPresent()) {
String firstPendingTimestamp = firstPendingInstant.get().getTimestamp();
- String lastCompleteTimestamp = lastCompleteInstant.get().getTimestamp();
- // Committed and pending compaction instants should have strictly lower timestamps
- return StreamerUtil.medianInstantTime(firstPendingTimestamp, lastCompleteTimestamp);
+ return StreamerUtil.incrementInstantTime(firstPendingTimestamp, 1);
} else {
return HoodieActiveTimeline.createNewInstantTime();
}
+
Review comment:
ditto
##########
File path: hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnReadWithCompact.java
##########
@@ -35,6 +35,9 @@
protected void setUp(Configuration conf) {
// trigger the compaction for every finished checkpoint
conf.setInteger(FlinkOptions.COMPACTION_DELTA_COMMITS, 1);
+ conf.setBoolean(FlinkOptions.COMPACTION_SCHEDULE_ENABLED, true);
+ conf.setBoolean(FlinkOptions.COMPACTION_ASYNC_ENABLED, true);
+
Review comment:
unnecessary white space
##########
File path: hudi-flink/src/test/java/org/apache/hudi/utils/TestStreamerUtil.java
##########
@@ -24,6 +24,7 @@
import org.apache.hudi.util.StreamerUtil;
import org.apache.flink.configuration.Configuration;
+
Review comment:
unnecessary white space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-961588354
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139",
"triggerID" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-961588354
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139",
"triggerID" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-1022786436
further design and discussion needed for async scheduling. closing this PR for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3637: [HUDI-2301]support async compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-916770374
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139",
"triggerID" : "da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da2fb4ad8ce58d0e8fb6abd579a04c2ebe15b09f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2139)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#issuecomment-916770374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#discussion_r718091146
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -430,14 +430,14 @@ private FlinkOptions() {
public static final ConfigOption<Boolean> COMPACTION_SCHEDULE_ENABLED = ConfigOptions
.key("compaction.schedule.enabled")
.booleanType()
- .defaultValue(true) // default true for MOR write
- .withDescription("Schedule the compaction plan, enabled by default for MOR");
+ .defaultValue(false) // default false for MOR write
Review comment:
Fine with the change.
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -486,8 +486,8 @@ private FlinkOptions() {
public static final ConfigOption<Boolean> CLEAN_ASYNC_ENABLED = ConfigOptions
.key("clean.async.enabled")
.booleanType()
- .defaultValue(true)
- .withDescription("Whether to cleanup the old commits immediately on new commits, enabled by default");
+ .defaultValue(false)
+ .withDescription("Whether to cleanup the old commits immediately on new commits, disabled by default");
Review comment:
We should keep it true, the cleaning logic also works for COW table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3637: [HUDI-2301] Support Flink async compaction scheduling
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3637:
URL: https://github.com/apache/hudi/pull/3637#discussion_r718092117
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -486,8 +486,8 @@ private FlinkOptions() {
public static final ConfigOption<Boolean> CLEAN_ASYNC_ENABLED = ConfigOptions
.key("clean.async.enabled")
.booleanType()
- .defaultValue(true)
- .withDescription("Whether to cleanup the old commits immediately on new commits, enabled by default");
+ .defaultValue(false)
+ .withDescription("Whether to cleanup the old commits immediately on new commits, disabled by default");
Review comment:
We should keep it true, the cleaning logic also works for COW table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org