You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/04 12:56:01 UTC

[GitHub] [flink] hililiwei opened a new pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

hililiwei opened a new pull request #17682:
URL: https://github.com/apache/flink/pull/17682


   #17106 (review)
   
   backport to release 1.12
   
   @AHeise 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #17682:
URL: https://github.com/apache/flink/pull/17682#issuecomment-960866547

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678 (Thu Nov 04 12:58:41 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #17682:
URL: https://github.com/apache/flink/pull/17682#issuecomment-960870159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25959",
       "triggerID" : "e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25959) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise commented on pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

AHeise commented on pull request #17682:
URL: https://github.com/apache/flink/pull/17682#issuecomment-961925059


   I just realized that 1.12 will probably not have a new release, so we can omit this backport. I would have merged it without compilation issue but it seems to require some more work.
   I'm closing for now - you can reopen if you still want to backport anyways.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise closed pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

AHeise closed pull request #17682:
URL: https://github.com/apache/flink/pull/17682


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise commented on pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

AHeise commented on pull request #17682:
URL: https://github.com/apache/flink/pull/17682#issuecomment-961925059


   I just realized that 1.12 will probably not have a new release, so we can omit this backport. I would have merged it without compilation issue but it seems to require some more work.
   I'm closing for now - you can reopen if you still want to backport anyways.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #17682:
URL: https://github.com/apache/flink/pull/17682#issuecomment-960870159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25959",
       "triggerID" : "e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25959) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise closed pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

AHeise closed pull request #17682:
URL: https://github.com/apache/flink/pull/17682


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #17682:
URL: https://github.com/apache/flink/pull/17682#issuecomment-960870159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e4270687dcc245f8a8ee2c4a62f3ef5d8fe16678 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise closed pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

AHeise closed pull request #17682:
URL: https://github.com/apache/flink/pull/17682


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise commented on pull request #17682: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

Posted by GitBox <gi...@apache.org>.

AHeise commented on pull request #17682:
URL: https://github.com/apache/flink/pull/17682#issuecomment-961925059


   I just realized that 1.12 will probably not have a new release, so we can omit this backport. I would have merged it without compilation issue but it seems to require some more work.
   I'm closing for now - you can reopen if you still want to backport anyways.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org