You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2015/10/27 18:17:51 UTC
[GitHub] flink pull request: [FLINK-2930] Respect ExecutionConfig execution...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1304
[FLINK-2930] Respect ExecutionConfig execution retry delay
This only affects job recovery on non-master failures.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink delay
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1304
----
commit 7c62b7ef2b30d9a95eb661c34032d705e9e23cf4
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-10-27T17:15:15Z
[FLINK-2930] Respect ExecutionConfig execution retry delay
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2930] Respect ExecutionConfig execution...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1304#issuecomment-152979209
+1, I also stumbled across the problem when I showed Aljoscha's demo at the Flink meetup in Paris.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2930] Respect ExecutionConfig execution...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1304#issuecomment-153311229
The problem is that the retries are hard coded in some other places. It was only working before this change, because it was actually not picked up anywhere. I will remove the hard coded parts. Also, I'm removing the getters and setters from the Environment. I don't think that it is the right place. We should keep it in the ExecutionConfig only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2930] Respect ExecutionConfig execution...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1304#issuecomment-153302034
@uce Builds seems to be failing. Can you look into it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2930] Respect ExecutionConfig execution...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1304#issuecomment-153317144
I've also added FLINK-2958 in this PR.
What's your opinion about FLINK-2959?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2930] Respect ExecutionConfig execution...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1304#issuecomment-152944847
This looks like a pretty big issue, actually.
+1 to merge this.
Might not be a release blocker, but if there is another RC, I would add this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2930] Respect ExecutionConfig execution...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2930] Respect ExecutionConfig execution...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1304#issuecomment-153386537
Thanks for fixing. Merging commits for FLINK-2930 and FLINK-2958.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---