You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/10 05:08:58 UTC
[PR] test(nameserver): pin the nameserver restart contract [rocketmq-dashboard]
zjncs opened a new pull request, #6036:
URL: https://github.com/apache/rocketmq-dashboard/pull/6036
### What
`RestartNameServerDTO` carries a NameServer restart. It had no dedicated test (only indirect use in controller tests). This adds 3 tests.
### What is pinned
- a valid request passes untouched;
- **the cluster is required** and **the address is required** — a request that names neither machine nor cluster must fail validation instead of restarting an arbitrary node.
### Verification
- New tests on unmodified code: **3/3 green**, checkstyle clean.
- Discriminating mutation: the `addr` constraint message drifted (red).
- Restored: 3/3 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(nameserver): pin the nameserver restart contract [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #6036: test(nameserver): pin the nameserver restart contract
URL: https://github.com/apache/rocketmq-dashboard/pull/6036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(nameserver): pin the nameserver restart contract [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #6036:
URL: https://github.com/apache/rocketmq-dashboard/pull/6036#issuecomment-6714911248
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org