[GitHub] [spark] jchen5 commented on a diff in pull request #42007: [SPARK-44431][SQL] Fix behavior of null IN (empty list) in optimization rules

["jchen5 (via GitHub)" <gi...@apache.org>]

jchen5 commented on code in PR #42007:
URL: https://github.com/apache/spark/pull/42007#discussion_r1264806758


##########
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-null-semantics.sql:
##########
@@ -0,0 +1,57 @@
+create temp view v (c) as values (1), (null);
+create temp view v_empty (e) as select 1 where false;
+
+-- Note: tables and temp views hit different optimization/execution codepaths
+create table t(c int) using parquet;

Review Comment:
   👍 will update



##########
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/in-null-semantics.sql:
##########
@@ -0,0 +1,57 @@
+create temp view v (c) as values (1), (null);
+create temp view v_empty (e) as select 1 where false;
+
+-- Note: tables and temp views hit different optimization/execution codepaths
+create table t(c int) using parquet;

Review Comment:
   👍 will update



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org