You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/02/16 18:15:42 UTC
Review Request 43606: Fixing a suspect NPE string
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43606/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
Once in a while a test fails with an NPE in method Connection.scheduleAckTimeouts() using the variable ackConnectionGroup. This variable is set to null in setInUse().
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 74660da3d365941b1017e18d427f5d14832c8d93
Diff: https://reviews.apache.org/r/43606/diff/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 43606: Fixing a suspect NPE string
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43606/#review119332
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java (line 2677)
<https://reviews.apache.org/r/43606/#comment180648>
Is there no 'else' part to the 'if not null' statement? Otherwise looks good.
- Udo Kohlmeyer
On Feb. 16, 2016, 5:15 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43606/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 5:15 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Once in a while a test fails with an NPE in method Connection.scheduleAckTimeouts() using the variable ackConnectionGroup. This variable is set to null in setInUse().
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 74660da3d365941b1017e18d427f5d14832c8d93
>
> Diff: https://reviews.apache.org/r/43606/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 43606: Fixing a suspect NPE string
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43606/#review119388
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Feb. 16, 2016, 5:15 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43606/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 5:15 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Once in a while a test fails with an NPE in method Connection.scheduleAckTimeouts() using the variable ackConnectionGroup. This variable is set to null in setInUse().
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 74660da3d365941b1017e18d427f5d14832c8d93
>
> Diff: https://reviews.apache.org/r/43606/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 43606: Fixing a suspect NPE string
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43606/#review119495
-----------------------------------------------------------
Ship it!
Ship It!
- Jianxia Chen
On Feb. 16, 2016, 5:15 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43606/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 5:15 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Once in a while a test fails with an NPE in method Connection.scheduleAckTimeouts() using the variable ackConnectionGroup. This variable is set to null in setInUse().
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 74660da3d365941b1017e18d427f5d14832c8d93
>
> Diff: https://reviews.apache.org/r/43606/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>