You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <HT...@schubergphilis.com> on 2012/11/01 09:28:26 UTC
RE: Enabling test by default
Hey Rohit,
If the build breaks often we should fix the unit tests imho. I know there is still some work to be done to setup proper unittests, but turning of the tests again might send the wrong signal that we don't really care about proper unittests and testing in general.
That said, you can easiliy disable tests if the -DskipTests flag. So my proposal would be to leave tests enabled by default, fix tests that break (or fix the code if the test is ok).
Cheers,
Hugo
P.S. CC-ed the dev list, this is definitely something that needs to be discussed in public.
> -----Original Message-----
> From: Rohit Yadav [mailto:rohit.yadav@citrix.com]
> Sent: Thursday, November 01, 2012 9:10 AM
> To: Hugo Trippaers; Edison Su; Prasanna Santhanam
> Subject: Enabling test by default
>
> By enabling tests by default, my build breaks often.
> May I enable a profile 'test' so if one wants only then maven should runs
> tests; mvn -P developer,test install #etc.
>
> diff --git a/pom.xml b/pom.xml
> index 4b563b3..2173c2d 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -81,7 +81,7 @@
> <cs.jstl.version>1.2</cs.jstl.version>
> <cs.selenium.server.version>1.0-
> 20081010.060147</cs.selenium.server.version>
> <cs.vmware.api.version>4.1</cs.vmware.api.version>
> -
> + <skipTests>true</skipTests>
> </properties>
>
> <distributionManagement>
> @@ -348,6 +348,12 @@
> </modules>
> </profile>
> <profile>
> + <id>test</id>
> + <properties>
> + <skipTests>false</skipTests>
> + </properties>
> + </profile>
> + <profile>
> <id>vmware</id>
> <activation>
> <property>
RE: Enabling test by default
Posted by Rohit Yadav <ro...@citrix.com>.
Cool, Hugo you're right we should do that!
________________________________________
From: Chiradeep Vittal
Sent: Thursday, November 01, 2012 10:59 PM
To: CloudStack DeveloperList; Rohit Yadav; Edison Su; Prasanna Santhanam
Subject: Re: Enabling test by default
+1 to leaving the tests enabled
On 11/1/12 1:28 AM, "Hugo Trippaers" <HT...@schubergphilis.com> wrote:
>Hey Rohit,
>
>If the build breaks often we should fix the unit tests imho. I know there
>is still some work to be done to setup proper unittests, but turning of
>the tests again might send the wrong signal that we don't really care
>about proper unittests and testing in general.
>
>That said, you can easiliy disable tests if the -DskipTests flag. So my
>proposal would be to leave tests enabled by default, fix tests that break
>(or fix the code if the test is ok).
>
>Cheers,
>
>Hugo
>
>P.S. CC-ed the dev list, this is definitely something that needs to be
>discussed in public.
>
>
>> -----Original Message-----
>> From: Rohit Yadav [mailto:rohit.yadav@citrix.com]
>> Sent: Thursday, November 01, 2012 9:10 AM
>> To: Hugo Trippaers; Edison Su; Prasanna Santhanam
>> Subject: Enabling test by default
>>
>> By enabling tests by default, my build breaks often.
>> May I enable a profile 'test' so if one wants only then maven should
>>runs
>> tests; mvn -P developer,test install #etc.
>>
>> diff --git a/pom.xml b/pom.xml
>> index 4b563b3..2173c2d 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -81,7 +81,7 @@
>> <cs.jstl.version>1.2</cs.jstl.version>
>> <cs.selenium.server.version>1.0-
>> 20081010.060147</cs.selenium.server.version>
>> <cs.vmware.api.version>4.1</cs.vmware.api.version>
>> -
>> + <skipTests>true</skipTests>
>> </properties>
>>
>> <distributionManagement>
>> @@ -348,6 +348,12 @@
>> </modules>
>> </profile>
>> <profile>
>> + <id>test</id>
>> + <properties>
>> + <skipTests>false</skipTests>
>> + </properties>
>> + </profile>
>> + <profile>
>> <id>vmware</id>
>> <activation>
>> <property>
Re: Enabling test by default
Posted by Chiradeep Vittal <Ch...@citrix.com>.
+1 to leaving the tests enabled
On 11/1/12 1:28 AM, "Hugo Trippaers" <HT...@schubergphilis.com> wrote:
>Hey Rohit,
>
>If the build breaks often we should fix the unit tests imho. I know there
>is still some work to be done to setup proper unittests, but turning of
>the tests again might send the wrong signal that we don't really care
>about proper unittests and testing in general.
>
>That said, you can easiliy disable tests if the -DskipTests flag. So my
>proposal would be to leave tests enabled by default, fix tests that break
>(or fix the code if the test is ok).
>
>Cheers,
>
>Hugo
>
>P.S. CC-ed the dev list, this is definitely something that needs to be
>discussed in public.
>
>
>> -----Original Message-----
>> From: Rohit Yadav [mailto:rohit.yadav@citrix.com]
>> Sent: Thursday, November 01, 2012 9:10 AM
>> To: Hugo Trippaers; Edison Su; Prasanna Santhanam
>> Subject: Enabling test by default
>>
>> By enabling tests by default, my build breaks often.
>> May I enable a profile 'test' so if one wants only then maven should
>>runs
>> tests; mvn -P developer,test install #etc.
>>
>> diff --git a/pom.xml b/pom.xml
>> index 4b563b3..2173c2d 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -81,7 +81,7 @@
>> <cs.jstl.version>1.2</cs.jstl.version>
>> <cs.selenium.server.version>1.0-
>> 20081010.060147</cs.selenium.server.version>
>> <cs.vmware.api.version>4.1</cs.vmware.api.version>
>> -
>> + <skipTests>true</skipTests>
>> </properties>
>>
>> <distributionManagement>
>> @@ -348,6 +348,12 @@
>> </modules>
>> </profile>
>> <profile>
>> + <id>test</id>
>> + <properties>
>> + <skipTests>false</skipTests>
>> + </properties>
>> + </profile>
>> + <profile>
>> <id>vmware</id>
>> <activation>
>> <property>