You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Kohsuke Kawaguchi (JIRA)" <ji...@codehaus.org> on 2007/06/11 23:52:58 UTC
[jira] Created: (MASSEMBLY-217) needs to
report collision.
<outputFileNameMapping> needs to report collision.
--------------------------------------------------
Key: MASSEMBLY-217
URL: http://jira.codehaus.org/browse/MASSEMBLY-217
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Affects Versions: 2.2-beta-1
Reporter: Kohsuke Kawaguchi
If <outputFileNameMapping> maps two or more artifacts into the same name, it needs to be reported as an error.
Maven currently just takes the last one without reporting anything, and as a result I didn't notice that my assembly descriptor had a problem until I debug the plugin source code.
This problem is particularly made worse by a broken jar-with-dependencies example in [the documentation|http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html], which says:
{noformat}
<dependencySets>
<dependencySet>
<outputDirectory></outputDirectory>
<outputFileNameMapping></outputFileNameMapping>
<unpack>true</unpack>
<scope>runtime</scope>
</dependencySet>
</dependencySets>
{noformat}
... which maps every dependency to ""
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-217) needs to
report collision.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=148400#action_148400 ]
John Casey commented on MASSEMBLY-217:
--------------------------------------
FWIW, you can now gain a little more control over this using 2.2-beta-3-SNAPSHOT latest code. The fix for MASSEMBLY-285 will also fix this, particularly if you set:
{code:xml}
<archiverConfig>
<duplicateBehavior>fail</duplicateBehavior>
</archiverConfig>
{code}
Admittedly, we could probably find a better way of providing a better message for specific instances where mapped artifact file names overlap, but it would be a little confusing if a mapped artifact filename overlapped with another file in the archive that wasn't the result of outputFileNameMapping logic.
> <outputFileNameMapping> needs to report collision.
> --------------------------------------------------
>
> Key: MASSEMBLY-217
> URL: http://jira.codehaus.org/browse/MASSEMBLY-217
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Kohsuke Kawaguchi
> Fix For: 2.2-beta-3
>
> Attachments: massembly-217.patch
>
>
> If <outputFileNameMapping> maps two or more artifacts into the same name, it needs to be reported as an error.
> Maven currently just takes the last one without reporting anything, and as a result I didn't notice that my assembly descriptor had a problem until I debug the plugin source code.
> This problem is particularly made worse by a broken jar-with-dependencies example in [the documentation|http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html], which says:
> {noformat}
> <dependencySets>
> <dependencySet>
> <outputDirectory></outputDirectory>
> <outputFileNameMapping></outputFileNameMapping>
> <unpack>true</unpack>
> <scope>runtime</scope>
> </dependencySet>
> </dependencySets>
> {noformat}
> ... which maps every dependency to ""
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-217) needs to
report collision.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=148402#action_148402 ]
John Casey commented on MASSEMBLY-217:
--------------------------------------
BTW, that example of the jar-with-dependencies built-in descriptor is correct; outputFileNameMapping is NOT used when unpack == true.
> <outputFileNameMapping> needs to report collision.
> --------------------------------------------------
>
> Key: MASSEMBLY-217
> URL: http://jira.codehaus.org/browse/MASSEMBLY-217
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Kohsuke Kawaguchi
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: massembly-217.patch
>
>
> If <outputFileNameMapping> maps two or more artifacts into the same name, it needs to be reported as an error.
> Maven currently just takes the last one without reporting anything, and as a result I didn't notice that my assembly descriptor had a problem until I debug the plugin source code.
> This problem is particularly made worse by a broken jar-with-dependencies example in [the documentation|http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html], which says:
> {noformat}
> <dependencySets>
> <dependencySet>
> <outputDirectory></outputDirectory>
> <outputFileNameMapping></outputFileNameMapping>
> <unpack>true</unpack>
> <scope>runtime</scope>
> </dependencySet>
> </dependencySets>
> {noformat}
> ... which maps every dependency to ""
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-217) needs to
report collision.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MASSEMBLY-217.
--------------------------------
Resolution: Fixed
> <outputFileNameMapping> needs to report collision.
> --------------------------------------------------
>
> Key: MASSEMBLY-217
> URL: http://jira.codehaus.org/browse/MASSEMBLY-217
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Kohsuke Kawaguchi
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: massembly-217.patch
>
>
> If <outputFileNameMapping> maps two or more artifacts into the same name, it needs to be reported as an error.
> Maven currently just takes the last one without reporting anything, and as a result I didn't notice that my assembly descriptor had a problem until I debug the plugin source code.
> This problem is particularly made worse by a broken jar-with-dependencies example in [the documentation|http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html], which says:
> {noformat}
> <dependencySets>
> <dependencySet>
> <outputDirectory></outputDirectory>
> <outputFileNameMapping></outputFileNameMapping>
> <unpack>true</unpack>
> <scope>runtime</scope>
> </dependencySet>
> </dependencySets>
> {noformat}
> ... which maps every dependency to ""
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-217) needs to
report collision.
Posted by "Ruzicka Cestmir (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruzicka Cestmir updated MASSEMBLY-217:
--------------------------------------
Attachment: massembly-217.patch
A little patch for archive duplicity.
When archiver contains artifacts file, exception is thrown
> <outputFileNameMapping> needs to report collision.
> --------------------------------------------------
>
> Key: MASSEMBLY-217
> URL: http://jira.codehaus.org/browse/MASSEMBLY-217
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Kohsuke Kawaguchi
> Fix For: 2.2-beta-3
>
> Attachments: massembly-217.patch
>
>
> If <outputFileNameMapping> maps two or more artifacts into the same name, it needs to be reported as an error.
> Maven currently just takes the last one without reporting anything, and as a result I didn't notice that my assembly descriptor had a problem until I debug the plugin source code.
> This problem is particularly made worse by a broken jar-with-dependencies example in [the documentation|http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html], which says:
> {noformat}
> <dependencySets>
> <dependencySet>
> <outputDirectory></outputDirectory>
> <outputFileNameMapping></outputFileNameMapping>
> <unpack>true</unpack>
> <scope>runtime</scope>
> </dependencySet>
> </dependencySets>
> {noformat}
> ... which maps every dependency to ""
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-217) needs to
report collision.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-217:
---------------------------------
Fix Version/s: 2.2-beta-2
> <outputFileNameMapping> needs to report collision.
> --------------------------------------------------
>
> Key: MASSEMBLY-217
> URL: http://jira.codehaus.org/browse/MASSEMBLY-217
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Kohsuke Kawaguchi
> Fix For: 2.2-beta-2
>
>
> If <outputFileNameMapping> maps two or more artifacts into the same name, it needs to be reported as an error.
> Maven currently just takes the last one without reporting anything, and as a result I didn't notice that my assembly descriptor had a problem until I debug the plugin source code.
> This problem is particularly made worse by a broken jar-with-dependencies example in [the documentation|http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html], which says:
> {noformat}
> <dependencySets>
> <dependencySet>
> <outputDirectory></outputDirectory>
> <outputFileNameMapping></outputFileNameMapping>
> <unpack>true</unpack>
> <scope>runtime</scope>
> </dependencySet>
> </dependencySets>
> {noformat}
> ... which maps every dependency to ""
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-217) needs to
report collision.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-217:
---------------------------------
Assignee: John Casey
Fix Version/s: (was: 2.2)
2.2-beta-3
> <outputFileNameMapping> needs to report collision.
> --------------------------------------------------
>
> Key: MASSEMBLY-217
> URL: http://jira.codehaus.org/browse/MASSEMBLY-217
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1
> Reporter: Kohsuke Kawaguchi
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: massembly-217.patch
>
>
> If <outputFileNameMapping> maps two or more artifacts into the same name, it needs to be reported as an error.
> Maven currently just takes the last one without reporting anything, and as a result I didn't notice that my assembly descriptor had a problem until I debug the plugin source code.
> This problem is particularly made worse by a broken jar-with-dependencies example in [the documentation|http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html], which says:
> {noformat}
> <dependencySets>
> <dependencySet>
> <outputDirectory></outputDirectory>
> <outputFileNameMapping></outputFileNameMapping>
> <unpack>true</unpack>
> <scope>runtime</scope>
> </dependencySet>
> </dependencySets>
> {noformat}
> ... which maps every dependency to ""
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira