[GitHub] [avro] KyleSchoonover commented on pull request #1519: AVRO-3368: Marked value field obsolete in GenericFixed

[GitBox <gi...@apache.org>]

KyleSchoonover commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1030219518


   Currently my team uses both the Avro library and Confluents library to work with the schema repository.  And the biggest reason that I am going through this process is this merge request: https://github.com/confluentinc/confluent-kafka-dotnet/pull/1643
   
   The other reason is because I expect that my team will start deprecating using C# / .Net altogether and move to Java.  So until that happens I'm going to try to improve the quality and maintainability of this project.
   
   So I can either take the time to bring the library incrementally up to standards or I can sit around and wait to review these large sweeping changes.
   
   Typically this is how I will approach it:
   Follow the standards (Code Analysis, StyleCop, etc) because I assume that is how people want it done.  Now this project has so many "suggestions" that it's going to take a while to do this incrementally and maintain backwards compatibility.  Also CodeQL caught something just because I touched a file, still had to correct the problem to pass the CI/CD.
   
   Next step will be to start correcting code bugs. 
    - Better implementations
    - Better exception handling
    - More test coverage
   
   Last I will start adding new features.  This will probably lead to going for parity with the Java library.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org