[jira] [Closed] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-6705.
----------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Branch

Thanks Gareth,

Your patch is in trunk r1738900  

I considered this an improvement rather than a bug, so I did not backport.

If you (or anybody) see some enhancements or/and more usages of EntityQuery.queryPagedList() please create a new JIra. 

For EntityQuery.queryPagedList() usages, I looked up for ".maxRows(highIndex)" in java code and had a look at 2 cases (getProductCategoryAndLimitedMembers service Java implemenation and ProductSearchSession.getProductSearchResult() method) but it was more complicated than I thought so I gave up for now. 

> some files set viewIndex to 1 by default rather than 0
> ------------------------------------------------------
>
>                 Key: OFBIZ-6705
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6705
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Gareth Carter
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:        if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:        <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex = request.getParameter("viewIndex") ? Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:    viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:            viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)