You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2017/08/25 03:38:32 UTC
[GitHub] metamodel pull request #159: METAMODEL-1160 and METAMODEL-1163: Deserializat...
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/159
METAMODEL-1160 and METAMODEL-1163: Deserialization of legacy schema objects
Fixes both METAMODEL-1160 and METAMODEL-1163.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-1163-deserialize-relationship
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
commit 73dbe1ce47076f94fafa1123a04a9647808d6f7d
Author: Kasper Sørensen <i....@gmail.com>
Date: 2017-08-24T04:23:20Z
METAMODEL-1160: Implemented backwards compatible deserializer
commit cc709019f287653951f4212b4954edfab4925458
Author: Kasper Sørensen <i....@gmail.com>
Date: 2017-08-25T03:13:42Z
METAMODEL-1163: Added test files w. immutable+mutable serialized schemas
commit 68eb73380bba869235c7308e11d3e90e6ce9615b
Author: Kasper Sørensen <i....@gmail.com>
Date: 2017-08-25T03:28:07Z
Merge branch 'METAMODEL-1160' into METAMODEL-1163-deserialize-relationship
commit 0a0bae9367e45025a3824876eb4afbb1eb4374bb
Author: Kasper Sørensen <i....@gmail.com>
Date: 2017-08-25T03:37:01Z
METAMODEL-1163: Fixed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #159: METAMODEL-1160 and METAMODEL-1163: Deserialization of ...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/159
I know, but you shouldn't be doing whole-file reformats at all. Even with w=1, there's still big reformats.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #159: METAMODEL-1160 and METAMODEL-1163: Deserialization of ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/159
Superceeded by #160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #159: METAMODEL-1160 and METAMODEL-1163: Deserialization of ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/159
Oh damn, that's a tabs vs spaces thing... The old version of those files seems to have tabs, contrary to our guidelines.
Is it possible to read if you add the w=1 param like this:
https://github.com/apache/metamodel/pull/159/files?w=1
?
Or should I reproduce the tabs in those files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #159: METAMODEL-1160 and METAMODEL-1163: Deserializat...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen closed the pull request at:
https://github.com/apache/metamodel/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #159: METAMODEL-1160 and METAMODEL-1163: Deserialization of ...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/159
We can do like we did in DataCleaner: Have one whole project commit that does whole-project reformat. It's still a bit annoying history-wise, but since it will be clearly marked as a reformatting commit, it's easy for anyone to see that they just need to go back one more commit to look for functional changes.
When it's done in commits like this one, it's really, really annoying to hunt through the history for causes of bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #159: METAMODEL-1160 and METAMODEL-1163: Deserialization of ...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/159
Not really a readable PR, lots of unnecessary reformatting going on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---