You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/20 23:05:24 UTC

[GitHub] [airflow] SamWheating commented on a change in pull request #18394: Add hook_params in SqlSensor

SamWheating commented on a change in pull request #18394:
URL: https://github.com/apache/airflow/pull/18394#discussion_r712572582



##########
File path: airflow/models/connection.py
##########
@@ -308,7 +311,7 @@ def get_hook(self):
                 "Could not import %s when discovering %s %s", hook_class_name, hook_name, package_name
             )
             raise
-        return hook_class(**{conn_id_param: self.conn_id})
+        return hook_class(**{conn_id_param: self.conn_id}, **hook_params)

Review comment:
       ```suggestion
           return hook_class(conn_id_param=self.conn_id, **hook_params)
   ```
   
   Maybe I'm missing something but I don't understand the usage of dictionary unpacking for a predetermined dictionary here 🤔 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org