[GitHub] [flink] tillrohrmann commented on a change in pull request #10682: [FLINK-15247][Runtime] Wait for all slots to be free before task executor services shutdown upon stopping

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #10682: [FLINK-15247][Runtime] Wait for all slots to be free before task executor services shutdown upon stopping
URL: https://github.com/apache/flink/pull/10682#discussion_r362825084
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorSubmissionTest.java
 ##########
 @@ -157,6 +159,9 @@ public void testTaskSubmission() throws Exception {
 			tmGateway.submitTask(tdd, env.getJobMasterId(), timeout).get();
 
 			taskRunningFuture.get();
+			taskFinishedFuture.get();
+
+			taskSlotTable.removeTask(tdd.getExecutionAttemptId());
 
 Review comment:
   Why do we have to explicitly call `removeTask`? This seems to be quite cumbersome.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services