[jira] Commented: (DIRMINA-40) Filter API needs callback for enabled notification

["Trustin Lee (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/DIRMINA-40?page=comments#action_65582 ]
     
Trustin Lee commented on DIRMINA-40:
------------------------------------

I modified SSLFilter to create SSLHandler at every events to resolve that issue.  SSLHandler is created when SSLHandler interface is not found in its internal map now.

FilterEnabled() and filterDisabled() is a good idea, but adding a filter to an acceptor causes some problem:

* A lot of events are fired at once to cause overload
* SessionManagers have to manage the list of sessions, and we have to handle concurrecy issues while iterating session list.

I think it is best for filter developers to check any data associated with session is initialized before filtering IMHO.

> Filter API needs callback for enabled notification
> --------------------------------------------------
>
>          Key: DIRMINA-40
>          URL: http://issues.apache.org/jira/browse/DIRMINA-40
>      Project: Directory MINA
>         Type: Improvement
>     Versions: 0.7, 0.7.1
>  Environment: All
>     Reporter: Vinod Panicker
>     Assignee: Trustin Lee
>     Priority: Blocker

>
> The Filter api currently assumes that it would be applied only on unopened sessions.  Eg - the SSL filter currently starts its work on the sessionOpened() callback.  This is an incorrect assumption since the SSL filter could be applied on an existing plain TCP connection as well.
> It would be great if there were new callbacks defined  - something like filterEnabled() and filterDisabled()
> This would allow us to use the filters on existing sessions as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira