You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/06/16 23:44:01 UTC
Review Request 35538: [MESOS-1988] Remove unused drop(...) overload
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35538/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1988
https://issues.apache.org/jira/browse/MESOS-1988
Repository: mesos
Description
-------
The library (src/scheduler/scheduler.cpp) already does the right thing of not doing anything and just dropping requests when it is dis-connected from the master. This change just deletes the unused overload that is no longer being used.
Also note that this does not change the existing driver implementation ( src/sched/sched.cpp ) which sends a "TASK_LOST" back when disconnected from the master. This behavior would be changed later.
(More info on JIRA)
Diffs
-----
src/scheduler/scheduler.cpp af18c6bb8bcbe0912246cdf9e84ee183924ea298
Diff: https://reviews.apache.org/r/35538/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 35538: [MESOS-1988] Remove unused drop(...)
overload
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35538/#review88155
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 16, 2015, 9:44 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35538/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 9:44 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1988
> https://issues.apache.org/jira/browse/MESOS-1988
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The library (src/scheduler/scheduler.cpp) already does the right thing of not doing anything and just dropping requests when it is dis-connected from the master. This change just deletes the unused overload that is no longer being used.
>
> Also note that this does not change the existing driver implementation ( src/sched/sched.cpp ) which sends a "TASK_LOST" back when disconnected from the master. This behavior would be changed later.
>
> (More info on JIRA)
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp af18c6bb8bcbe0912246cdf9e84ee183924ea298
>
> Diff: https://reviews.apache.org/r/35538/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 35538: [MESOS-1988] Remove unused drop(...)
overload
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35538/#review88137
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On June 16, 2015, 9:44 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35538/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 9:44 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1988
> https://issues.apache.org/jira/browse/MESOS-1988
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The library (src/scheduler/scheduler.cpp) already does the right thing of not doing anything and just dropping requests when it is dis-connected from the master. This change just deletes the unused overload that is no longer being used.
>
> Also note that this does not change the existing driver implementation ( src/sched/sched.cpp ) which sends a "TASK_LOST" back when disconnected from the master. This behavior would be changed later.
>
> (More info on JIRA)
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp af18c6bb8bcbe0912246cdf9e84ee183924ea298
>
> Diff: https://reviews.apache.org/r/35538/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>