You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/04 14:06:38 UTC

Review Request 38124: Add V1 Support for QuiesceOffers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add V1 Support for QuiesceOffers


Diffs
-----

  include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55 
  src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
  src/master/validation.cpp ffb7bf07b8a40d6e14f922eabcf46045462498b5 

Diff: https://reviews.apache.org/r/38124/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38124: Add V1 Support for QuiesceOffers

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/#review99076
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38124/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add V1 Support for QuiesceOffers
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/master/validation.cpp ffb7bf07b8a40d6e14f922eabcf46045462498b5 
> 
> Diff: https://reviews.apache.org/r/38124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38124: Add V1 Support for QuiesceOffers

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/#review99449
-----------------------------------------------------------

Ship it!



src/tests/scheduler_tests.cpp (line 1021)
<https://reviews.apache.org/r/38124/#comment156338>

    s/we enabled quiesce offer/the framework quiesced offers./



src/tests/scheduler_tests.cpp (lines 1030 - 1031)
<https://reviews.apache.org/r/38124/#comment156339>

    // Framework should receive offers only after calling reviving offers.


- Vinod Kone


On Sept. 16, 2015, 6:01 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38124/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 6:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add V1 Support for QuiesceOffers
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/scheduler/scheduler.proto 0118b46afca8a5adecb0e65981dd44bb98333bab 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/38124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38124: Add V1 Support for QuiesceOffers

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/#review99485
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37532, 37873, 38119, 38120, 38121, 38124]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 3:57 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38124/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 3:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add V1 Support for QuiesceOffers
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/scheduler/scheduler.proto 0118b46afca8a5adecb0e65981dd44bb98333bab 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/38124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38124: Add V1 Support for QuiesceOffers

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/
-----------------------------------------------------------

(Updated 九月 18, 2015, 3:57 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Changes
-------

Address vinod's comments


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add V1 Support for QuiesceOffers


Diffs (updated)
-----

  include/mesos/v1/scheduler/scheduler.proto 0118b46afca8a5adecb0e65981dd44bb98333bab 
  src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
  src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
  src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 

Diff: https://reviews.apache.org/r/38124/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38124: Add V1 Support for QuiesceOffers

Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/#review99358
-----------------------------------------------------------

Ship it!


Ship It!

- Jian Qiu


On Sept. 16, 2015, 6:01 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38124/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 6:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add V1 Support for QuiesceOffers
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/scheduler/scheduler.proto 0118b46afca8a5adecb0e65981dd44bb98333bab 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/38124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38124: Add V1 Support for QuiesceOffers

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/#review99197
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37532, 37873, 38119, 38120, 38121, 38124]

All tests passed.

- Mesos ReviewBot


On Sept. 16, 2015, 6:01 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38124/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 6:01 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add V1 Support for QuiesceOffers
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/scheduler/scheduler.proto 0118b46afca8a5adecb0e65981dd44bb98333bab 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/38124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38124: Add V1 Support for QuiesceOffers

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/
-----------------------------------------------------------

(Updated 九月 16, 2015, 6:01 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add V1 Support for QuiesceOffers


Diffs (updated)
-----

  include/mesos/v1/scheduler/scheduler.proto 0118b46afca8a5adecb0e65981dd44bb98333bab 
  src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
  src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
  src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 

Diff: https://reviews.apache.org/r/38124/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38124: Add V1 Support for QuiesceOffers

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/
-----------------------------------------------------------

(Updated 九月 16, 2015, 5:49 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add V1 Support for QuiesceOffers


Diffs (updated)
-----

  include/mesos/v1/scheduler/scheduler.proto 0118b46afca8a5adecb0e65981dd44bb98333bab 
  src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
  src/master/validation.cpp f97eba650f91e975859c2bbf0614ee5d39cf035e 
  src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 

Diff: https://reviews.apache.org/r/38124/diff/


Testing
-------


Thanks,

Guangya Liu