You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/02 15:41:00 UTC

[jira] [Commented] (AIRFLOW-6428) Add dates module to airflow/utils/__init__.py

    [ https://issues.apache.org/jira/browse/AIRFLOW-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006873#comment-17006873 ] 

ASF GitHub Bot commented on AIRFLOW-6428:
-----------------------------------------

kaxil commented on pull request #7007: [AIRFLOW-6428] Add dates module to airflow/utils/__init__.py
URL: https://github.com/apache/airflow/pull/7007
 
 
   Currently, without the entry in __init__.py, IDEs show that it could not find the reference to dates in most of our example_dags as they contain `airflow.utils.dates.days_ago(1)` and hence if you try to find the reference for days_ago function or dates modules it can't find it.
   
   ![image](https://user-images.githubusercontent.com/8811558/71675633-1b8f7a00-2d76-11ea-97d4-3ddeff029d13.png)
   ![image](https://user-images.githubusercontent.com/8811558/71675654-277b3c00-2d76-11ea-8123-c47d1ef7ef1d.png)
   
   
   ---
   - [x] Description above provides context of the change
   - [x] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add dates module to airflow/utils/__init__.py
> ---------------------------------------------
>
>                 Key: AIRFLOW-6428
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6428
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: utils
>    Affects Versions: 1.10.7
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Major
>             Fix For: 1.10.8
>
>         Attachments: image-2020-01-02-15-33-55-601.png
>
>
> Currently, without the entry in __init__.py, IDEs show that it could not find the reference to *dates* and hence if you try to find the reference for *days_ago* function or *dates* modules it can't find it.
> Check attachment



--
This message was sent by Atlassian Jira
(v8.3.4#803005)