You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/22 21:06:11 UTC

[GitHub] [arrow] kou commented on a change in pull request #7818: ARROW-9541: [C++] CMakeLists requires UTF8PROC_STATIC when building static library

kou commented on a change in pull request #7818:
URL: https://github.com/apache/arrow/pull/7818#discussion_r459082935



##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -488,6 +488,9 @@ add_dependencies(arrow ${ARROW_LIBRARIES})
 
 if(ARROW_BUILD_STATIC AND WIN32)
   target_compile_definitions(arrow_static PUBLIC ARROW_STATIC)
+  if(ARROW_WITH_UTF8PROC)
+    target_compile_definitions(arrow_static PUBLIC UTF8PROC_STATIC)

Review comment:
       I think that it has a problem when we use shared utf8proc for the arrow static library.
   How about using `INTERFACE_COMPILER_DEFINITIONS` property like https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2125-L2126 ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org