You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/17 03:40:39 UTC
[GitHub] srowen commented on issue #23263: [SPARK-23674][ML] Adds Spark ML
Events
srowen commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
URL: https://github.com/apache/spark/pull/23263#issuecomment-447713637
I can't think of a better approach; for what it's trying to do that's about the cleanest way. I think the changes are OK.
Maybe a smaller change that is still viable is indeed to put this in Pipeline rather than the implementations. That is, you only get this if you use Pipeline, sure, but that seems like the use case. Pipeline's code can be the bit that fires off events (right?) rather than reinstrumenting all the other classes. Is that possible or missing a bigger opportunity?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org